Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small refactorings as preparation for UPDATE queries #1353

Merged
merged 5 commits into from
May 22, 2024

Conversation

Qup42
Copy link
Member

@Qup42 Qup42 commented May 22, 2024

A set of smaller refactoring changes, most of which come from an early proof of concept implementation of SPARQL UPDATE by @hannahbast.
Those include:

  • Updating and adding comments in various places.
  • Unifying the header formats in various files.
  • Making the debug output of ValueIds shorter (V:3 rater than Vocabindex:3).

Copy link

codecov bot commented May 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.79%. Comparing base (0ff6f76) to head (f2a07d2).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1353      +/-   ##
==========================================
- Coverage   88.79%   88.79%   -0.01%     
==========================================
  Files         324      324              
  Lines       28650    28653       +3     
  Branches     3170     3171       +1     
==========================================
+ Hits        25441    25442       +1     
- Misses       2060     2062       +2     
  Partials     1149     1149              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@joka921 joka921 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have a very small suggestion that would be very useful ( a longstanding issue, that can help us with debugging.

src/global/ValueId.h Outdated Show resolved Hide resolved
@joka921 joka921 changed the title Refactoring in preparation for #1351 Small refactorings as preparation for UPDATE queries May 22, 2024
Copy link

Quality Gate Passed Quality Gate passed

Issues
3 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@joka921 joka921 merged commit d63028c into ad-freiburg:master May 22, 2024
18 of 19 checks passed
@namedgraph
Copy link

"Update queries" are not a thing, they're just "updates" :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants