-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Small refactorings as preparation for UPDATE queries #1353
Conversation
To avoid duplication this change will only be in ad-freiburg#1354
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1353 +/- ##
==========================================
- Coverage 88.79% 88.79% -0.01%
==========================================
Files 324 324
Lines 28650 28653 +3
Branches 3170 3171 +1
==========================================
+ Hits 25441 25442 +1
- Misses 2060 2062 +2
Partials 1149 1149 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have a very small suggestion that would be very useful ( a longstanding issue, that can help us with debugging.
Quality Gate passedIssues Measures |
"Update queries" are not a thing, they're just "updates" :) |
A set of smaller refactoring changes, most of which come from an early proof of concept implementation of SPARQL UPDATE by @hannahbast.
Those include:
ValueId
s shorter (V:3
rater thanVocabindex:3
).