-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make "Map view" URL configurable in backend settings #106
Conversation
@Qup42 I've seen your PR. Many thanks. |
The default admin is demo/demo. You can also always create a new admin user with |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Several rounds of reviewing together with Julian. Great work, thanks a lot!
When a query results contains WKT literals in its last column, a "Map view" button appears. A click on that button leads to an instance of https://github.com/ad-freiburg/qlever-petrimaps, which visualizes the result.
So far, this only worked for selected backends, and it was hard-coded in
backend/static/js/qleverUI.js
which ones. Now this can be configured invididually for each backend, via a fieldMap view base URL
. The URL should be the base URL of theqlever-petrimaps
instance. When the field is empty (which is the default), no "Map View" button is shown for that backend. Fixes #102 . Since a new field was added to the backend configuration, this requires a migration.