Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make "Map view" URL configurable in backend settings #106

Merged
merged 14 commits into from
Sep 23, 2024

Conversation

Qup42
Copy link
Member

@Qup42 Qup42 commented Sep 23, 2024

When a query results contains WKT literals in its last column, a "Map view" button appears. A click on that button leads to an instance of https://github.com/ad-freiburg/qlever-petrimaps, which visualizes the result.

So far, this only worked for selected backends, and it was hard-coded in backend/static/js/qleverUI.js which ones. Now this can be configured invididually for each backend, via a field Map view base URL. The URL should be the base URL of the qlever-petrimaps instance. When the field is empty (which is the default), no "Map View" button is shown for that backend. Fixes #102 . Since a new field was added to the backend configuration, this requires a migration.

@NicoLaval
Copy link

@Qup42 I've seen your PR. Many thanks.
What are the default credentials to access to the Admin tab?

@Qup42
Copy link
Member Author

Qup42 commented Sep 23, 2024

The default admin is demo/demo. You can also always create a new admin user with python3 manage.py createsuperuser.

@hannahbast hannahbast changed the title Make "Map view" configurable in backend settings Make "Map view" URL configurable in backend settings Sep 23, 2024
@Qup42 Qup42 marked this pull request as ready for review September 23, 2024 19:18
Copy link
Member

@hannahbast hannahbast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Several rounds of reviewing together with Julian. Great work, thanks a lot!

@hannahbast hannahbast merged commit 177ef3a into ad-freiburg:master Sep 23, 2024
@Qup42 Qup42 mentioned this pull request Sep 24, 2024
@Qup42 Qup42 deleted the configurePetrimaps branch September 24, 2024 10:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Document how to have the "Map view" button
3 participants