Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Optimize Dockerfile and add action for pushing it to DockerHub #16

Merged
merged 6 commits into from
Dec 17, 2024
Merged

Optimize Dockerfile and add action for pushing it to DockerHub #16

merged 6 commits into from
Dec 17, 2024

Conversation

Qup42
Copy link
Member

@Qup42 Qup42 commented Sep 24, 2024 •
edited by hannahbast
Loading

Add a GitHub action that automatically builds an image and pushes it to the docker registry. Use the occasion to optimize the Dockerfile.

@Qup42 Qup42 requested a review from patrickbr September 24, 2024 10:51
@hannahbast
Copy link
Member

@Qup42 Thanks a lot! Can you give me instructions on exactly which secret should I create?

@Qup42
Copy link
Member Author

Qup42 commented Sep 24, 2024

@Qup42 Thanks a lot! Can you give me instructions on exactly which secret should I create?

These secrets have to be created:

  • DOCKERHUB_USERNAME: Docker Hub username
  • DOCKERHUB_TOKEN: a personal access token that can push to the registry

This was referenced Nov 26, 2024
Open
Open
@Qup42 Qup42 changed the title Deploy Build optimized container image in CI Dec 17, 2024
@Qup42 Qup42 marked this pull request as ready for review December 17, 2024 14:11
hannahbast
hannahbast approved these changes Dec 17, 2024
View reviewed changes
Copy link
Member

@hannahbast hannahbast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thanks a lot!

@hannahbast hannahbast changed the title Build optimized container image in CI Optimize Dockerfile and add action for pushing it to DockerHub Dec 17, 2024
@hannahbast hannahbast merged commit 9beca55 into ad-freiburg:master Dec 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hannahbast hannahbast hannahbast approved these changes

@patrickbr patrickbr Awaiting requested review from patrickbr

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Qup42 @hannahbast