Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix icon hover effect in transaction table #4070

Merged
merged 3 commits into from
Jan 2, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions packages/desktop-client/e2e/schedules.test.js
Original file line number Diff line number Diff line change
Expand Up @@ -58,6 +58,10 @@ test.describe('Schedules', () => {
await expect(transaction.debit).toHaveText('25.00');
await expect(transaction.credit).toHaveText('');

const icon = transaction.payee.getByTestId('schedule-icon');
await icon.hover();
await expect(page).toMatchThemeScreenshots();

// go to rules page
const rulesPage = await navigation.goToRulesPage();
await rulesPage.searchFor('Home Depot');
Expand Down
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Original file line number Diff line number Diff line change
Expand Up @@ -699,40 +699,42 @@ function PayeeCell({
);

return (
<div
style={{
overflow: 'hidden',
textOverflow: 'ellipsis',
display: 'flex',
alignItems: 'center',
}}
>
<>
<PayeeIcons
transaction={transaction}
transferAccount={transferAccount}
onNavigateToTransferAccount={onNavigateToTransferAccount}
onNavigateToSchedule={onNavigateToSchedule}
/>
{importedPayee ? (
<Tooltip
content={
<View style={{ padding: 10 }}>
<Text style={{ fontWeight: 'bold' }}>Imported Payee</Text>
<Text style={{ fontWeight: 'normal' }}>
{importedPayee}
</Text>
</View>
}
style={{ ...styles.tooltip, borderRadius: '0px 5px 5px 0px' }}
placement="bottom"
triggerProps={{ delay: 750 }}
>
{payeeName}
</Tooltip>
) : (
payeeName
)}
</div>
<div
style={{
overflow: 'hidden',
textOverflow: 'ellipsis',
display: 'flex',
alignItems: 'center',
}}
>
{importedPayee ? (
<Tooltip
content={
<View style={{ padding: 10 }}>
<Text style={{ fontWeight: 'bold' }}>Imported Payee</Text>
<Text style={{ fontWeight: 'normal' }}>
{importedPayee}
</Text>
</View>
}
style={{ ...styles.tooltip, borderRadius: '0px 5px 5px 0px' }}
placement="bottom"
triggerProps={{ delay: 750 }}
>
{payeeName}
</Tooltip>
) : (
payeeName
)}
</div>
</>
);
}}
>
Expand Down Expand Up @@ -804,6 +806,7 @@ function PayeeIcons({
{schedule && (
<Button
variant="bare"
data-testid="schedule-icon"
aria-label="See schedule details"
style={payeeIconButtonStyle}
onPress={() => {
Expand All @@ -820,6 +823,7 @@ function PayeeIcons({
{transferAccount && (
<Button
variant="bare"
data-testid="transfer-icon"
aria-label="See transfer account"
style={payeeIconButtonStyle}
onPress={() => {
Expand Down
6 changes: 6 additions & 0 deletions upcoming-release-notes/4070.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
---
category: Bugfix
authors: [jfdoming]
---

Fix regression in hover effect for icons
Loading