Fix icon hover effect in transaction table #4070

jfdoming · 2025-01-02T07:15:54Z

Follow-up to #4056—that PR was almost the right fix but inadvertently caused a small regression with the hover effect on icons.

Edge:

This PR:

Also note that this still fixes the original issue, which specifically only reproed for imported payees.
Last release:

This PR:

netlify · 2025-01-02T07:16:14Z

✅ Deploy Preview for actualbudget ready!

Name	Link
🔨 Latest commit	`fcf112b`
🔍 Latest deploy log	https://app.netlify.com/sites/actualbudget/deploys/67764bc94770bb0008a0eed2
😎 Deploy Preview	https://deploy-preview-4070.demo.actualbudget.org
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

github-actions · 2025-01-02T07:17:25Z

Bundle Stats — desktop-client

Hey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle.

As this PR is updated, I'll keep you updated on how the bundle size is impacted.

Total

Files count	Total bundle size	% Changed
10	5.64 MB → 5.64 MB (+265 B)	+0.00%

Changeset

File	Δ	Size
`src/components/transactions/TransactionsTable.jsx`	📈 +265 B (+0.39%)	67.11 kB → 67.37 kB

View detailed bundle breakdown

Added

No assets were added

Removed

No assets were removed

Bigger

Asset	File Size	% Changed
static/js/index.js	3.71 MB → 3.71 MB (+265 B)	+0.01%

Smaller

No assets were smaller

Unchanged

Asset	File Size	% Changed
static/js/indexeddb-main-thread-worker-e59fee74.js	13.5 kB	0%
static/js/workbox-window.prod.es5.js	5.69 kB	0%
static/js/resize-observer.js	18.37 kB	0%
static/js/BackgroundImage.js	122.29 kB	0%
static/js/AppliedFilters.js	10.24 kB	0%
static/js/useAccountPreviewTransactions.js	1.63 kB	0%
static/js/narrow.js	83.36 kB	0%
static/js/wide.js	104.11 kB	0%
static/js/ReportRouter.js	1.58 MB	0%

github-actions · 2025-01-02T07:17:26Z

Bundle Stats — loot-core

Hey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle.

As this PR is updated, I'll keep you updated on how the bundle size is impacted.

Total

Files count	Total bundle size	% Changed
1	1.33 MB	0%

Changeset

No files were changed

View detailed bundle breakdown

Added

No assets were added

Removed

No assets were removed

Bigger

No assets were bigger

Smaller

No assets were smaller

Unchanged

Asset	File Size	% Changed
kcab.worker.js	1.33 MB	0%

jfdoming · 2025-01-02T08:09:08Z

/update-vrt

coderabbitai · 2025-01-02T08:38:46Z

Warning

There were issues while running some tools. Please review the errors and either fix the tool’s configuration or disable the tool if it’s a critical failure.

🔧 eslint

If the error stems from missing dependencies, add them to the package.json file. For unrecoverable errors (e.g., due to private dependencies), disable the tool in the CodeRabbit configuration.

packages/desktop-client/e2e/schedules.test.js

Oops! Something went wrong! :(

ESLint: 8.57.1

ESLint couldn't find the plugin "eslint-plugin-eslint-plugin".

(The package "eslint-plugin-eslint-plugin" was not found when loaded as a Node module from the directory "/packages/eslint-plugin-actual".)

It's likely that the plugin isn't installed correctly. Try reinstalling by running the following:

npm install eslint-plugin-eslint-plugin@latest --save-dev

The plugin "eslint-plugin-eslint-plugin" was referenced from the config file in "packages/eslint-plugin-actual/.eslintrc.js".

If you still can't figure out the problem, please stop by https://eslint.org/chat/help to chat with the team.

Walkthrough

The pull request introduces changes to two files: packages/desktop-client/e2e/schedules.test.js and packages/desktop-client/src/components/transactions/TransactionsTable.jsx. In the test file, a new test case is added that involves hovering over a schedule icon and verifying its visual representation through theme screenshots. In the TransactionsTable.jsx component, the changes include using a fragment instead of a <div> in the PayeeCell function and adding data-testid attributes to schedule and transfer account icon buttons in the PayeeIcons function, which improves testability and code structure.

Possibly related PRs

Fix: #3719: Imported payee overflowing on transaction record #3753: Modifies Tooltip.tsx, which is relevant to the hover action in the schedule icon test
Fix payee cell overflowing when it contains an icon #4056: Addresses rendering issues in TransactionsTable.jsx, directly related to the component modifications

Suggested labels

sparkles: Merged

Suggested reviewers

matt-fidd
MikesGlitch

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Generate unit testing code for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit testing code for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and generate unit testing code.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

coderabbitai

Actionable comments posted: 0

🧹 Nitpick comments (1)

packages/desktop-client/e2e/schedules.test.js (1)

62-63: Good approach to test hover state with visual regression!

By hovering over the element and capturing the screenshot, you verify that the UI behaves as expected under user interaction. This is an excellent way to ensure CSS and layout changes do not inadvertently break the hover effect. Keep in mind that visual regression tests can sometimes be sensitive to timing; consider implementing a small wait if there are intermittent test stability issues.

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 1e65939 and fcf112b.

⛔ Files ignored due to path filters (10)

packages/desktop-client/e2e/schedules.test.js-snapshots/Schedules-creates-a-new-schedule-posts-the-transaction-and-later-completes-it-10-chromium-linux.png is excluded by !**/*.png
packages/desktop-client/e2e/schedules.test.js-snapshots/Schedules-creates-a-new-schedule-posts-the-transaction-and-later-completes-it-11-chromium-linux.png is excluded by !**/*.png
packages/desktop-client/e2e/schedules.test.js-snapshots/Schedules-creates-a-new-schedule-posts-the-transaction-and-later-completes-it-12-chromium-linux.png is excluded by !**/*.png
packages/desktop-client/e2e/schedules.test.js-snapshots/Schedules-creates-a-new-schedule-posts-the-transaction-and-later-completes-it-13-chromium-linux.png is excluded by !**/*.png
packages/desktop-client/e2e/schedules.test.js-snapshots/Schedules-creates-a-new-schedule-posts-the-transaction-and-later-completes-it-14-chromium-linux.png is excluded by !**/*.png
packages/desktop-client/e2e/schedules.test.js-snapshots/Schedules-creates-a-new-schedule-posts-the-transaction-and-later-completes-it-15-chromium-linux.png is excluded by !**/*.png
packages/desktop-client/e2e/schedules.test.js-snapshots/Schedules-creates-a-new-schedule-posts-the-transaction-and-later-completes-it-7-chromium-linux.png is excluded by !**/*.png
packages/desktop-client/e2e/schedules.test.js-snapshots/Schedules-creates-a-new-schedule-posts-the-transaction-and-later-completes-it-8-chromium-linux.png is excluded by !**/*.png
packages/desktop-client/e2e/schedules.test.js-snapshots/Schedules-creates-a-new-schedule-posts-the-transaction-and-later-completes-it-9-chromium-linux.png is excluded by !**/*.png
upcoming-release-notes/4070.md is excluded by !**/*.md

📒 Files selected for processing (2)

packages/desktop-client/e2e/schedules.test.js (1 hunks)
packages/desktop-client/src/components/transactions/TransactionsTable.jsx (3 hunks)

✅ Files skipped from review due to trivial changes (1)

packages/desktop-client/src/components/transactions/TransactionsTable.jsx

🔇 Additional comments (1)

packages/desktop-client/e2e/schedules.test.js (1)

61-61: Great addition of a test ID for the schedule icon!

The introduction of getByTestId('schedule-icon') makes it much more straightforward and robust for test automation. This ensures consistent element targeting and reduces the risk of test fragility due to future DOM structure changes.

matt-fidd

Oops, thanks for catching

matt-fidd

Could you check the VRT snapshots before merging? Some of them look wrong but I can only see on mobile at the moment

matt-fidd

ah, I see - it's just because they've been renumbered

jfdoming · 2025-01-02T16:45:52Z

ah, I see - it's just because they've been renumbered

Yeah sorry, wasn't sure how to avoid that 😅 maybe we should start providing names for them or something. Future improvement!

Fix icon hover effect in transaction table

6372659

actual-github-bot bot added the 🚧 WIP label Jan 2, 2025

Add release notes

913e5fa

Add test

fcf112b

jfdoming force-pushed the jfdoming/fix-icon-hover branch from 59c1362 to fcf112b Compare January 2, 2025 08:18

jfdoming marked this pull request as ready for review January 2, 2025 08:25

actual-github-bot bot added 🔍 Ready for review and removed 🚧 WIP labels Jan 2, 2025

jfdoming requested a review from matt-fidd January 2, 2025 08:25

jfdoming added this to the v25.1.0 milestone Jan 2, 2025

coderabbitai bot reviewed Jan 2, 2025

View reviewed changes

matt-fidd approved these changes Jan 2, 2025

View reviewed changes

actual-github-bot bot added ✅ Approved and removed 🔍 Ready for review labels Jan 2, 2025

matt-fidd requested changes Jan 2, 2025

View reviewed changes

actual-github-bot bot added ⚠️ Changes requested and removed ✅ Approved labels Jan 2, 2025

matt-fidd approved these changes Jan 2, 2025

View reviewed changes

actual-github-bot bot added ✅ Approved and removed ⚠️ Changes requested labels Jan 2, 2025

jfdoming merged commit be5bfa2 into actualbudget:master Jan 2, 2025
20 checks passed

actual-github-bot bot added ✨ Merged and removed ✅ Approved labels Jan 2, 2025

jfdoming deleted the jfdoming/fix-icon-hover branch January 2, 2025 16:46

This was referenced Jan 2, 2025

🌍 improve translation strings - part 1 #4041

Merged

Migrate Account component to a functional component and use the new useTransactions hook #3708

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix icon hover effect in transaction table #4070

Fix icon hover effect in transaction table #4070

jfdoming commented Jan 2, 2025

netlify bot commented Jan 2, 2025 •

edited

Loading

github-actions bot commented Jan 2, 2025 •

edited

Loading

github-actions bot commented Jan 2, 2025 •

edited

Loading

jfdoming commented Jan 2, 2025

coderabbitai bot commented Jan 2, 2025

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (`.coderabbit.yaml`)

Documentation and Community

coderabbitai bot left a comment

matt-fidd left a comment

matt-fidd left a comment

matt-fidd left a comment

jfdoming commented Jan 2, 2025

Fix icon hover effect in transaction table #4070

Fix icon hover effect in transaction table #4070

Conversation

jfdoming commented Jan 2, 2025

netlify bot commented Jan 2, 2025 • edited Loading

✅ Deploy Preview for actualbudget ready!

github-actions bot commented Jan 2, 2025 • edited Loading

Bundle Stats — desktop-client

github-actions bot commented Jan 2, 2025 • edited Loading

Bundle Stats — loot-core

jfdoming commented Jan 2, 2025

coderabbitai bot commented Jan 2, 2025

Walkthrough

Possibly related PRs

Suggested labels

Suggested reviewers

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

coderabbitai bot left a comment

Choose a reason for hiding this comment

matt-fidd left a comment

Choose a reason for hiding this comment

matt-fidd left a comment

Choose a reason for hiding this comment

matt-fidd left a comment

Choose a reason for hiding this comment

jfdoming commented Jan 2, 2025

netlify bot commented Jan 2, 2025 •

edited

Loading

github-actions bot commented Jan 2, 2025 •

edited

Loading

github-actions bot commented Jan 2, 2025 •

edited

Loading

CodeRabbit Configuration File (`.coderabbit.yaml`)