Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 remove 'we have been notified' copy #1155

Merged
merged 2 commits into from
Jun 20, 2023
Merged

🐛 remove 'we have been notified' copy #1155

merged 2 commits into from
Jun 20, 2023

Conversation

MatissJanis
Copy link
Member

Closes #1069

I've not actually tested this change. Which is why I'm not changing it to direct links (as they might not work).

Instead I'm just applying a very quick patch so the message would not be misleading anymore.

@netlify
Copy link

netlify bot commented Jun 20, 2023

Deploy Preview for actualbudget ready!

Name Link
🔨 Latest commit dfec78f
🔍 Latest deploy log https://app.netlify.com/sites/actualbudget/deploys/649200d28301e10009cc73a2
😎 Deploy Preview https://deploy-preview-1155--actualbudget.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

Copy link
Contributor

@j-f1 j-f1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool! If you want you should be able to return a JSX fragment with arbitrary components in it.

@MatissJanis MatissJanis merged commit c286f1c into master Jun 20, 2023
@MatissJanis MatissJanis deleted the matiss/1069 branch June 20, 2023 19:56
@trafico-bot trafico-bot bot added ✨ Merged Pull Request has been merged successfully and removed ✅ Approved labels Jun 20, 2023
TomAFrench added a commit to TomAFrench/actual that referenced this pull request Jun 24, 2023
* master: (54 commits)
  New linter rule import/no-unused-modules & fixing import on typescript (actualbudget#1173)
  React Router 6 fixes (actualbudget#1178)
  Remove remaining tutorial code (actualbudget#1174)
  react-router 6 upgrade (actualbudget#1066)
  Deleting all unused files, deleting unused functions from loot-core (actualbudget#1158)
  Log more details when migrations are out of sync (actualbudget#1161)
  Remove upgrade notifications code (actualbudget#1156)
  🔥  removing needs-triage github label (actualbudget#1157)
  Tidy up exports in loot-core (actualbudget#1147)
  🐛  remove 'we have been notified' copy (actualbudget#1155)
  Updates to the server button at the top right (actualbudget#1141)
  Expand / collapse all categories (actualbudget#1143)
  ✨ (nordigen) release the feature (actualbudget#1135)
  Improve error logging in the API (actualbudget#1121)
  ♻️ (crdt) moved re-used utils in actual-server to separate package (actualbudget#1150)
  Removing Tutorial code (actualbudget#1146)
  Removing unused functions (actualbudget#1145)
  Revert “Make number parsing agnostic to decimal and thousands separators” (actualbudget#1144)
  Strip a trailing slash off of server URLs (actualbudget#1140)
  Update CONTRIBUTING.md to point to the website (actualbudget#1138)
  ...
TomAFrench added a commit to TomAFrench/actual that referenced this pull request Jun 24, 2023
* master: (54 commits)
  New linter rule import/no-unused-modules & fixing import on typescript (actualbudget#1173)
  React Router 6 fixes (actualbudget#1178)
  Remove remaining tutorial code (actualbudget#1174)
  react-router 6 upgrade (actualbudget#1066)
  Deleting all unused files, deleting unused functions from loot-core (actualbudget#1158)
  Log more details when migrations are out of sync (actualbudget#1161)
  Remove upgrade notifications code (actualbudget#1156)
  🔥  removing needs-triage github label (actualbudget#1157)
  Tidy up exports in loot-core (actualbudget#1147)
  🐛  remove 'we have been notified' copy (actualbudget#1155)
  Updates to the server button at the top right (actualbudget#1141)
  Expand / collapse all categories (actualbudget#1143)
  ✨ (nordigen) release the feature (actualbudget#1135)
  Improve error logging in the API (actualbudget#1121)
  ♻️ (crdt) moved re-used utils in actual-server to separate package (actualbudget#1150)
  Removing Tutorial code (actualbudget#1146)
  Removing unused functions (actualbudget#1145)
  Revert “Make number parsing agnostic to decimal and thousands separators” (actualbudget#1144)
  Strip a trailing slash off of server URLs (actualbudget#1140)
  Update CONTRIBUTING.md to point to the website (actualbudget#1138)
  ...
FlorianLang06 pushed a commit to FlorianLang06/actual that referenced this pull request Mar 7, 2024
Closes actualbudget#1069

I've not actually tested this change. Which is why I'm not changing it
to direct links (as they might not work).

Instead I'm just applying a very quick patch so the message would not be
misleading anymore.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
✨ Merged Pull Request has been merged successfully
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Actual import error message claims errors are automatically reported
2 participants