Strip a trailing slash off of server URLs #1140
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for actualbudget ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
MatissJanis
reviewed
Jun 16, 2023
Co-authored-by: Matiss Janis Aboltins <[email protected]>
MatissJanis
approved these changes
Jun 16, 2023
trafico-bot
bot
added
✨ Merged
TomAFrench
added a commit
to TomAFrench/actual
that referenced
this pull request
Jun 24, 2023
* master: (54 commits) New linter rule import/no-unused-modules & fixing import on typescript (actualbudget#1173) React Router 6 fixes (actualbudget#1178) Remove remaining tutorial code (actualbudget#1174) react-router 6 upgrade (actualbudget#1066) Deleting all unused files, deleting unused functions from loot-core (actualbudget#1158) Log more details when migrations are out of sync (actualbudget#1161) Remove upgrade notifications code (actualbudget#1156) 🔥 removing needs-triage github label (actualbudget#1157) Tidy up exports in loot-core (actualbudget#1147) 🐛 remove 'we have been notified' copy (actualbudget#1155) Updates to the server button at the top right (actualbudget#1141) Expand / collapse all categories (actualbudget#1143) ✨ (nordigen) release the feature (actualbudget#1135) Improve error logging in the API (actualbudget#1121) ♻️ (crdt) moved re-used utils in actual-server to separate package (actualbudget#1150) Removing Tutorial code (actualbudget#1146) Removing unused functions (actualbudget#1145) Revert “Make number parsing agnostic to decimal and thousands separators” (actualbudget#1144) Strip a trailing slash off of server URLs (actualbudget#1140) Update CONTRIBUTING.md to point to the website (actualbudget#1138) ...
TomAFrench
added a commit
to TomAFrench/actual
that referenced
this pull request
Jun 24, 2023
* master: (54 commits) New linter rule import/no-unused-modules & fixing import on typescript (actualbudget#1173) React Router 6 fixes (actualbudget#1178) Remove remaining tutorial code (actualbudget#1174) react-router 6 upgrade (actualbudget#1066) Deleting all unused files, deleting unused functions from loot-core (actualbudget#1158) Log more details when migrations are out of sync (actualbudget#1161) Remove upgrade notifications code (actualbudget#1156) 🔥 removing needs-triage github label (actualbudget#1157) Tidy up exports in loot-core (actualbudget#1147) 🐛 remove 'we have been notified' copy (actualbudget#1155) Updates to the server button at the top right (actualbudget#1141) Expand / collapse all categories (actualbudget#1143) ✨ (nordigen) release the feature (actualbudget#1135) Improve error logging in the API (actualbudget#1121) ♻️ (crdt) moved re-used utils in actual-server to separate package (actualbudget#1150) Removing Tutorial code (actualbudget#1146) Removing unused functions (actualbudget#1145) Revert “Make number parsing agnostic to decimal and thousands separators” (actualbudget#1144) Strip a trailing slash off of server URLs (actualbudget#1140) Update CONTRIBUTING.md to point to the website (actualbudget#1138) ...
FlorianLang06
pushed a commit
to FlorianLang06/actual
that referenced
this pull request
Mar 7, 2024
URLs with the trailing slash don’t work well — requests end up being made to `https://example.com//sync/sync` and such which can 404 --------- Co-authored-by: Matiss Janis Aboltins <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
URLs with the trailing slash don’t work well — requests end up being made to
https://example.com//sync/syncand such which can 404