chore: Bump minimum GeoModel version to 6.3.0 #3476
Conversation
github-actions
bot
added
the
Infrastructure
|
@krasznaa CMake seems stable now if you want to have a look. I have to check the unit test |
|
More than 10 files need patching so I am giving up on that. This is blocked until we have an external build of GeoModel in the CI |
paulgessinger
changed the title
|
| @@ -352,7 +349,8 @@ jobs: | |||
| -DCMAKE_PREFIX_PATH="${{ env.DEPENDENCY_DIR }}" | |||
| -DPython_EXECUTABLE=${{ env.DEPENDENCY_DIR }}/bin/python3 | |||
| -DCMAKE_INSTALL_PREFIX="${{ env.INSTALL_DIR }}" | |||
| -DACTS_BUILD_EXAMPLES_PYTHON_BINDINGS=OFF | |||
| -DACTS_BUILD_PLUGIN_GEOMODEL=ON | |||
| -DACTS_BUILD_EXAMPLES_PYTHON_BINDINGS=ON | |||
There was a problem hiding this comment.
I don't know why this was off, but I think I'd prefer if we continue testing this build on macOS as well.
There was a problem hiding this comment.
I think this should be enabled with the preset?
There was a problem hiding this comment.
I don't believe it is. The Linux jobs also enable this manually I believe.
There was a problem hiding this comment.
for GitHub Actions it should be ON by default https://github.com/acts-project/acts/blob/1d0a641dfa0a1f4ff3fb898df7c3b3d1642c18d3/CMakePresets.json#L19C18-L19C53
I guess it was switched OFF because we didn't built that before #3135 either
AJPfleger
added
automerge
and removed
🛑 blocked
paulgessinger
added
🛑 blocked
acts-project-service
added
the
Breaks Athena build
Bumps GeoModel version and deals with the necessary changes. This is a subset of #3268 which isolates the version change and tackles the CI errors faced there.