feat: GeoShapes to DetectorVolumes and GeoMaterial Converters

[Matthewharri]

This PR introduces a converter to convert geoShapes to DetectorVolumes. Some of the shapes added are very simple converters, i.e. simple bounding boxes which will probably be changed later on. I also bump the GeoModel version from 4.6.0 to 6.0.0 since Athena is using a much newer version. I also change (with the help of @paulgessinger) how cmake looks for the system installation of GeoModel.

I also include a way to convert GeoMaterial to Acts::Material

@junggjo9

blocked by

• chore: Bump minimum GeoModel version to 6.3.0 #3476

[github-actions]

📊: Physics performance monitoring for 7608689

Full contents

physmon summary

• ✅ Particles fatras
• ✅ Particles geant4
• ✅ Particles ttbar
• ✅ Vertices ttbar
• ✅ Truth tracking (KF)
• ✅ Truth tracking (GSF)
• ✅ Truth tracking (GX2F)
• ✅ CKF | trackfinding | single muon | truth smeared seeding
• ✅ Track Summary CKF | trackfinding | single muon | truth smeared seeding
• ✅ Seeding trackfinding | single muon | truth estimated seeding
• ✅ CKF | trackfinding | single muon | truth estimated seeding
• ✅ Track Summary CKF | trackfinding | single muon | truth estimated seeding
• ✅ Seeding trackfinding | single muon | default seeding
• ✅ CKF | trackfinding | single muon | default seeding
• ✅ Track Summary CKF | trackfinding | single muon | default seeding
• ✅ Seeding trackfinding | single muon | orthogonal seeding
• ✅ CKF | trackfinding | single muon | orthogonal seeding
• ✅ Track Summary CKF | trackfinding | single muon | orthogonal seeding
• ✅ Seeding trackfinding | 4 muon x 50 vertices | default seeding
• ✅ CKF | trackfinding | 4 muon x 50 vertices | default seeding
• ✅ Track Summary CKF | trackfinding | 4 muon x 50 vertices | default seeding
• ✅ Ambisolver | trackfinding | 4 muon x 50 vertices | default seeding
• ✅ IVF notime | trackfinding | 4 muon x 50 vertices | default seeding
• ✅ AMVF gauss notime | trackfinding | 4 muon x 50 vertices | default seeding
• ✅ AMVF grid time | trackfinding | 4 muon x 50 vertices | default seeding
• ✅ Seeding trackfinding | ttbar with 200 pileup | default seeding
• ✅ CKF | trackfinding | ttbar with 200 pileup | default seeding
• ✅ Track Summary CKF | trackfinding | ttbar with 200 pileup | default seeding
• ✅ Ambisolver | trackfinding | ttbar with 200 pileup | default seeding
• ✅ AMVF gauss notime | trackfinding | ttbar with 200 pileup | default seeding
• ✅ AMVF grid time | trackfinding | ttbar with 200 pileup | default seeding

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 47.31%. Comparing base (859e7af) to head (6b016ca).
Report is 43 commits behind head on main.

❗ Current head 6b016ca differs from pull request most recent head cd12571

Please upload reports for the commit cd12571 to get more accurate results.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #3268      +/-   ##
==========================================
- Coverage   47.37%   47.31%   -0.06%     
==========================================
  Files         511      512       +1     
  Lines       30249    30437     +188     
  Branches    14677    14795     +118     
==========================================
+ Hits        14329    14400      +71     
- Misses       5386     5404      +18     
- Partials    10534    10633      +99     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[paulgessinger]

Generally, this seems sensible to me.

1. Do we have any way to test this in an isolated way in CI?
2. Medium term, I'll likely want to reuse the volume bounds creation, as that will translate 1:1 into the Gen3 geometry model.

[Matthewharri]

@noemina should be all set now.

[noemina]

@Matthewharri it seems there is still a problem with the compilation?

[andiwand]

There seems to be a build error @Matthewharri https://github.com/acts-project/acts/actions/runs/10212537654/job/28256057425?pr=3268

[Matthewharri]

Apparently there was, but I think it should be fixed now.

[Matthewharri]

Ok, So this is now failing because there are warnings in the geomodel compilation, and it is treating those as errors. Any suggestions @noemina or @andiwand

[andiwand]

Ok, So this is now failing because there are warnings in the geomodel compilation, and it is treating those as errors. Any suggestions @noemina or @andiwand

Looking at the compile command

ccache /usr/bin/c++ -DGeoModelKernel_EXPORTS -I/__w/acts/acts/build/_deps/geomodel-src/GeoModelCore/GeoModelKernel -I/__w/acts/acts/build/_deps/geomodel-src/GeoModelCore/GeoGenericFunctions -isystem /__w/acts/acts/cmake/assert_include -isystem /usr/include/eigen3 -Wall -Wextra -Wpedantic -Wshadow -Wno-unused-local-typedefs -Werror -Wno-deprecated-declarations -O3 -DNDEBUG -std=c++20 -fPIC -MD -MT _deps/geomodel-build/GeoModelCore/GeoModelKernel/CMakeFiles/GeoModelKernel.dir/src/GeoNodeAction.cxx.o -MF _deps/geomodel-build/GeoModelCore/GeoModelKernel/CMakeFiles/GeoModelKernel.dir/src/GeoNodeAction.cxx.o.d -o _deps/geomodel-build/GeoModelCore/GeoModelKernel/CMakeFiles/GeoModelKernel.dir/src/GeoNodeAction.cxx.o -c /__w/acts/acts/build/_deps/geomodel-src/GeoModelCore/GeoModelKernel/src/GeoNodeAction.cxx

It seems that GeoModel is not included using -isystem but just -I which will cause the compiler to raise warnings in the included files. This means GeoModel is not integrated correctly in ACTS via CMake

[andiwand]

This is blocked by #3476 which is blocked by having an external build for GeoModel

[Matthewharri]

With #3476 merged in, the issue with the builds is fixed. Is this now good to be merged in? @noemina or @andiwand

[andiwand]

A couple of nitpicks from my side. Otherwise looks good to go

[Matthewharri]

@andiwand Ok, I addressed your things, so assuming nothing got messed up the CI should be fine, and then this is good to go

[andiwand]

should we override sonarcloud in this case @paulgessinger ?

[sonarcloud]

Quality Gate failed

Failed conditions
0.0% Coverage on New Code (required ≥ 25%)
0.0% Line Coverage on New Code (required ≥ 50%)

See analysis details on SonarCloud