Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Remove residual mentions of C++17 #3455

Merged
merged 2 commits into from
Jul 30, 2024
Merged

fix: Remove residual mentions of C++17 #3455

merged 2 commits into from
Jul 30, 2024

Commits on Jul 30, 2024

  1. fix: Remove residual mentions of C++17 

    This commit removes some residual mentions of C++17 in the source code
which have become irrelevant since the switch to C++20. Although most of
these are completely harmless, the `FindFilesystem.cmake` change is
actually important as it was setting `CMAKE_CXX_STANDARD` as a non-cache
variable, thereby overriding any other settings and potentially
reverting builds back to C++17, which was breaking some traccc builds as
@fredevb discovered.
    @stephenswat
    stephenswat committed Jul 30, 2024
    Configuration menu
    Copy the full SHA
    d1726a4 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' into fix/cxx_17_residue

    @kodiakhq
    kodiakhq[bot] authored Jul 30, 2024
    Configuration menu
    Copy the full SHA
    4faa9e4 View commit details
    Browse the repository at this point in the history