fix: Remove residual mentions of C++17 #3455
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
Infrastructure
stephenswat
changed the title
stephenswat
force-pushed
the
fix/cxx_17_residue
branch
from
be4fcf4
to
d1726a4
Compare
This commit removes some residual mentions of C++17 in the source code which have become irrelevant since the switch to C++20. Although most of these are completely harmless, the `FindFilesystem.cmake` change is actually important as it was setting `CMAKE_CXX_STANDARD` as a non-cache variable, thereby overriding any other settings and potentially reverting builds back to C++17, which was breaking some traccc builds as @fredevb discovered.
📊: Physics performance monitoring for 4faa9e4physmon summary
|
|
acts-project-service
added
the
Fails Athena tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit removes some residual mentions of C++17 in the source code which have become irrelevant since the switch to C++20. Although most of these are completely harmless, the
FindFilesystem.cmakechange is actually important as it was settingCMAKE_CXX_STANDARDas a non-cache variable, thereby overriding any other settings and potentially reverting builds back to C++17, which was breaking some traccc builds as @fredevb discovered.