feat: Introduce scope failure threshold helper #3290
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AJPfleger
approved these changes
Jun 13, 2024
📊: Physics performance monitoring for 0d4b365physmon summary
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3290 +/- ##
=======================================
Coverage 47.36% 47.36%
=======================================
Files 511 511
Lines 30260 30260
Branches 14680 14680
=======================================
Hits 14333 14333
Misses 5389 5389
Partials 10538 10538 ☔ View full report in Codecov by Sentry. |
kodiakhq bot
pushed a commit
that referenced
this pull request
Jun 14, 2024
This PR allows merging of two cylinder and disc surfaces. Merging is allowed in the $z$ and $r\times\phi$ direction for cylinders, and in the $r$ and $\phi$ direction for discs. The surfaces need to be consistent, i.e. their bounds dimensions and transforms need to line up. - For **cylinders**: - $z$ merging: $z$ edges must be aligned, no relative $xy$ shift or any rotation is allowed. - $r\times\phi$ merging: $r\times\phi$ edges must be aligned, no $xyz$ shift or any rotation is allowed - For **discs**: - $r$ merging: $r$ edges must be aligned, no $xyz$ shift or rotation is allowed - $\phi$ merging: $\phi$ edges must be aligned, no $xyz$ shift or rotation is allowed.   Blocked by: - #3290
Matthewharri
pushed a commit
to Matthewharri/acts
that referenced
this pull request
Jun 18, 2024
This PR adds a RAII helper that sets a specific log threshold scope until it is destroyed. This is helpful mostly for unit tests where we need to suppress failure due to (expected) error messages.
Matthewharri
pushed a commit
to Matthewharri/acts
that referenced
this pull request
Jun 18, 2024
This PR allows merging of two cylinder and disc surfaces. Merging is allowed in the $z$ and $r\times\phi$ direction for cylinders, and in the $r$ and $\phi$ direction for discs. The surfaces need to be consistent, i.e. their bounds dimensions and transforms need to line up. - For **cylinders**: - $z$ merging: $z$ edges must be aligned, no relative $xy$ shift or any rotation is allowed. - $r\times\phi$ merging: $r\times\phi$ edges must be aligned, no $xyz$ shift or any rotation is allowed - For **discs**: - $r$ merging: $r$ edges must be aligned, no $xyz$ shift or rotation is allowed - $\phi$ merging: $\phi$ edges must be aligned, no $xyz$ shift or rotation is allowed.   Blocked by: - acts-project#3290
timadye
pushed a commit
to andiwand/acts
that referenced
this pull request
Jun 27, 2024
This PR adds a RAII helper that sets a specific log threshold scope until it is destroyed. This is helpful mostly for unit tests where we need to suppress failure due to (expected) error messages.
timadye
pushed a commit
to andiwand/acts
that referenced
this pull request
Jun 27, 2024
This PR allows merging of two cylinder and disc surfaces. Merging is allowed in the $z$ and $r\times\phi$ direction for cylinders, and in the $r$ and $\phi$ direction for discs. The surfaces need to be consistent, i.e. their bounds dimensions and transforms need to line up. - For **cylinders**: - $z$ merging: $z$ edges must be aligned, no relative $xy$ shift or any rotation is allowed. - $r\times\phi$ merging: $r\times\phi$ edges must be aligned, no $xyz$ shift or any rotation is allowed - For **discs**: - $r$ merging: $r$ edges must be aligned, no $xyz$ shift or rotation is allowed - $\phi$ merging: $\phi$ edges must be aligned, no $xyz$ shift or rotation is allowed.   Blocked by: - acts-project#3290
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a RAII helper that sets a specific log threshold scope until it is destroyed. This is helpful mostly for unit tests where we need to suppress failure due to (expected) error messages.