fix: Unit test hough transform and fix identifier bug

[dimitra97]

This PR introduces a Unit Test for the Hough transform by taking hardcoded the data for the MuonSimHit and the DriftCircles (since we just want to test the TransformUtils and not the readers). We check one station and we pick also the corresponding sim hit for this station from the csv files.

Also it fixes a bug with the bit shift operation in the MuonSimHit.hpp because we observed a problem (with @janheinri during the tracking workshop) when the stationEta was negative so we cast it to unsigned int
Tagging people that may be interested: @goblirsc @junggjo9 @janheinri (if you also want to review :) )

[github-actions]

📊: Physics performance monitoring for 9d755aa

Full contents

physmon summary

• ✅ CKF truth_smeared
• ✅ IVF truth_smeared
• ✅ AMVF truth_smeared
• ✅ Track Summary CKF truth_smeared
• ✅ Seeding truth_estimated
• ✅ CKF truth_estimated
• ✅ IVF truth_estimated
• ✅ AMVF truth_estimated
• ✅ Track Summary CKF truth_estimated
• ✅ Seeding seeded
• ✅ CKF seeded
• ✅ IVF seeded
• ✅ AMVF seeded
• ✅ AMVF (+grid seeder) seeded
• ✅ Track Summary CKF seeded
• ✅ Seeding orthogonal
• ✅ CKF orthogonal
• ✅ IVF orthogonal
• ✅ AMVF orthogonal
• ✅ Track Summary CKF orthogonal
• ✅ Ambisolver seeded
• ✅ Ambisolver orthogonal
• ✅ Seeding ttbar
• ✅ CKF ttbar
• ✅ Ambisolver
• ✅ Track Summary CKF ttbar
• ✅ AMVF ttbar
• ✅ AMVF (+grid seeder) ttbar
• ✅ Truth tracking (GSF)
• ✅ Truth tracking
• ✅ Truth tracking (GX2F)
• ✅ Particles fatras
• ✅ Particles geant4

[goblirsc]

Hi,

thanks a lot @dimitra97 @janheinri !
I added a few comments from my end, including a proposal for how we can avoid the ActsExamples dependency.

Cheers, Max

[dimitra97]

Hi,

thanks a lot @dimitra97 @janheinri ! I added a few comments from my end, including a proposal for how we can avoid the ActsExamples dependency.

Cheers, Max

Hello Max, ok I if we want to discard ActsExamples dependency I will follow the comments and make the changes!
Thanks,
Dimitra

[paulgessinger]

I like it!

[janheinri]

I don't think I have anything valuable to add which wasn't mentioned already

Invalidated by push of 3e8cd4e

[sonarcloud]

Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

[acts-project-service]

✅ Athena integration test results [a283841]

✅ All tests successful

status	job	report
🟢	run_unit_tests
🟢	test_ActsDumpGeometryIdentifiers
🟢	test_ActsCheckObjectCountsWorkflow
🟢	test_ActsEFTrackFit
🟢	test_ActsPersistifySeeds
🟢	test_ActsBenchmarkWithSpot
🟢	test_ActsAnalogueClustering
🟢	test_ActsWorkflowHeavyIons
🟢	test_ActsWorkflowFastTracking
🟢	test_ActsWorkflowCached
🟢	test_ActsWorkflow
🟢	test_ActsValidateAmbiguityResolution
🟢	test_ActsValidateResolvedTracks
🟢	test_ActsValidateTracks
🟢	test_ActsValidateActsCoreSpacePoints
🟢	test_ActsValidateActsSpacePoints
🟢	test_ActsValidateSeeds
🟢	test_ActsValidateOrthogonalSeeds
🟢	test_ActsValidateClusters
🟢	test_ActsPersistifyEDM
🟢	test_ActsGSFRefitting
🟢	test_ActsKfRefitting
🟢	test_ActsExtrapolationAlgTest
🟢	test_ActsITkTest
🟢	run_workflow_tests_run4_mc
🟢	run_workflow_tests_run2_mc
🟢	run_workflow_tests_run2_data
🟢	run_workflow_tests_run3_mc
🟢	run_workflow_tests_run3_data
🟢	run_art_test: test_data18_13TeV_1000evt
🟢	run_art_test: test_ttbarPU40_reco