Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Reintroduce branch stopping on measurement in Core CKF #3172

Merged
merged 3 commits into from
May 7, 2024
Merged

feat: Reintroduce branch stopping on measurement in Core CKF #3172

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
559a49f
feat: Reintroduce branch stopping on measurement in Core CKF
andiwand May 6, 2024
ee33d83
shuffle
andiwand May 6, 2024
97d3087
Merge branch 'main' into feat-ckf-reint-stop-on-meas
kodiakhq[bot] May 7, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 19 additions & 2 deletions Core/include/Acts/TrackFinding/CombinatorialKalmanFilter.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -890,9 +890,26 @@ class CombinatorialKalmanFilter {

// Put tipstate back into active tips to continue with it
result.activeTips.emplace_back(currentTip, tipState);
// Record the number of branches on surface
nBranchesOnSurface++;

using BranchStopperResult =
CombinatorialKalmanFilterBranchStopperResult;
BranchStopperResult branchStopperResult =
m_extensions.branchStopper(tipState, trackState);

// Check if need to stop this branch
if (branchStopperResult == BranchStopperResult::Continue) {
// Record the number of branches on surface
nBranchesOnSurface++;
} else {
if (branchStopperResult == BranchStopperResult::StopAndKeep) {
storeLastActiveTip(result);
}

// Remove the tip from list of active tips
result.activeTips.erase(result.activeTips.end() - 1);
}
}

return Result<void>::success();
}

Expand Down
Loading