feat: Reintroduce branch stopping on measurement in Core CKF #3172
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
📊: Physics performance monitoring for 97d3087physmon summary
|
CarloVarni
approved these changes
May 7, 2024
asalzburger
pushed a commit
to asalzburger/acts
that referenced
this pull request
May 21, 2024
…oject#3172) After removing this in acts-project#3102 I reintroduce this functionality here to reduce the changes to a minimum. After acts-project#3102 we see some bigger tack finding changes than expected which I suspect are coming from the fact that we effectively stopped most of the branches when reaching a measurement surface. Having this callback will also be necessary if we want to allow the user to count holes/outliers/measurements in specific geometry regions by themselves.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After removing this in #3102 I reintroduce this functionality here to reduce the changes to a minimum. After #3102 we see some bigger tack finding changes than expected which I suspect are coming from the fact that we effectively stopped most of the branches when reaching a measurement surface.
Having this callback will also be necessary if we want to allow the user to count holes/outliers/measurements in specific geometry regions by themselves.