feat: allow to created BinnedMaterialMaps from configured ProtoGridMaterialMaps #3109
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
📊: Physics performance monitoring for 47e64d6physmon summary
|
asalzburger
changed the title
Ragansu
pushed a commit
to Ragansu/acts
that referenced
this pull request
Apr 19, 2024
…terialMaps (acts-project#3109) This PR allows to use a Gen1 `BinnedSurfaceMaterial` creation from a Gen2 `ProtoGridSurfaceMaterial` configuration. The vice-versa approach will be part of another PR. This can be tested with ODD Gen1 / Gen2 geometries by: ```sh python ~/Documents/work/dev/acts-grid-material-prs/Examples/Scripts/Python/material_mapping_core.py -i geant4_material_tracks.root -o odd_gen2_material -m odd_gen2_material_maps ``` and for Gen2: ```sh python ~/Documents/work/dev/acts-grid-material-prs/Examples/Scripts/Python/material_mapping_core.py -i geant4_material_tracks.root -o odd_gen2_material -m odd_gen2_material_maps --experimental ```
kodiakhq bot
pushed a commit
that referenced
this pull request
May 1, 2024
This PR introduces (optimally navigation-less) material validation using core components. It agrees very with the propagation based one, see below:  This PR now enables full support for `BinnedSurfaceMaterial` and `HomogeneousSurfaceMaterial` for Gen1 and Gen2 geometry. While #3094 and #3109 enabled the creation of `.json` and `.root` maps from both Gen1 and Gen2 material, this one allows to test them. E.g. for the ODD: *Gen1 geometry:* ```sh python ~/Documents/work/dev/acts-grid-material-prs/Examples/Scripts/Python/material_validation_core.py -o odd_gen1_material_validation_root -n 1000 -t 1000 -m odd_gen1_material_maps.root ``` *Gen2 geometry:* ```sh python ~/Documents/work/dev/acts-grid-material-prs/Examples/Scripts/Python/material_validation_core.py -o odd_gen2_material_validation_root -n 1000 -t 1000 -m odd_gen2_material_maps.root --experimental ```
EleniXoch
pushed a commit
to EleniXoch/acts
that referenced
this pull request
May 6, 2024
…terialMaps (acts-project#3109) This PR allows to use a Gen1 `BinnedSurfaceMaterial` creation from a Gen2 `ProtoGridSurfaceMaterial` configuration. The vice-versa approach will be part of another PR. This can be tested with ODD Gen1 / Gen2 geometries by: ```sh python ~/Documents/work/dev/acts-grid-material-prs/Examples/Scripts/Python/material_mapping_core.py -i geant4_material_tracks.root -o odd_gen2_material -m odd_gen2_material_maps ``` and for Gen2: ```sh python ~/Documents/work/dev/acts-grid-material-prs/Examples/Scripts/Python/material_mapping_core.py -i geant4_material_tracks.root -o odd_gen2_material -m odd_gen2_material_maps --experimental ```
EleniXoch
pushed a commit
to EleniXoch/acts
that referenced
this pull request
May 6, 2024
) This PR introduces (optimally navigation-less) material validation using core components. It agrees very with the propagation based one, see below:  This PR now enables full support for `BinnedSurfaceMaterial` and `HomogeneousSurfaceMaterial` for Gen1 and Gen2 geometry. While acts-project#3094 and acts-project#3109 enabled the creation of `.json` and `.root` maps from both Gen1 and Gen2 material, this one allows to test them. E.g. for the ODD: *Gen1 geometry:* ```sh python ~/Documents/work/dev/acts-grid-material-prs/Examples/Scripts/Python/material_validation_core.py -o odd_gen1_material_validation_root -n 1000 -t 1000 -m odd_gen1_material_maps.root ``` *Gen2 geometry:* ```sh python ~/Documents/work/dev/acts-grid-material-prs/Examples/Scripts/Python/material_validation_core.py -o odd_gen2_material_validation_root -n 1000 -t 1000 -m odd_gen2_material_maps.root --experimental ```
asalzburger
added a commit
to asalzburger/acts
that referenced
this pull request
May 21, 2024
…terialMaps (acts-project#3109) This PR allows to use a Gen1 `BinnedSurfaceMaterial` creation from a Gen2 `ProtoGridSurfaceMaterial` configuration. The vice-versa approach will be part of another PR. This can be tested with ODD Gen1 / Gen2 geometries by: ```sh python ~/Documents/work/dev/acts-grid-material-prs/Examples/Scripts/Python/material_mapping_core.py -i geant4_material_tracks.root -o odd_gen2_material -m odd_gen2_material_maps ``` and for Gen2: ```sh python ~/Documents/work/dev/acts-grid-material-prs/Examples/Scripts/Python/material_mapping_core.py -i geant4_material_tracks.root -o odd_gen2_material -m odd_gen2_material_maps --experimental ```
asalzburger
added a commit
to asalzburger/acts
that referenced
this pull request
May 21, 2024
) This PR introduces (optimally navigation-less) material validation using core components. It agrees very with the propagation based one, see below:  This PR now enables full support for `BinnedSurfaceMaterial` and `HomogeneousSurfaceMaterial` for Gen1 and Gen2 geometry. While acts-project#3094 and acts-project#3109 enabled the creation of `.json` and `.root` maps from both Gen1 and Gen2 material, this one allows to test them. E.g. for the ODD: *Gen1 geometry:* ```sh python ~/Documents/work/dev/acts-grid-material-prs/Examples/Scripts/Python/material_validation_core.py -o odd_gen1_material_validation_root -n 1000 -t 1000 -m odd_gen1_material_maps.root ``` *Gen2 geometry:* ```sh python ~/Documents/work/dev/acts-grid-material-prs/Examples/Scripts/Python/material_validation_core.py -o odd_gen2_material_validation_root -n 1000 -t 1000 -m odd_gen2_material_maps.root --experimental ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR allows to use a Gen1
BinnedSurfaceMaterialcreation from a Gen2ProtoGridSurfaceMaterialconfiguration.The vice-versa approach will be part of another PR.
This can be tested with ODD Gen1 / Gen2 geometries by:
python ~/Documents/work/dev/acts-grid-material-prs/Examples/Scripts/Python/material_mapping_core.py -i geant4_material_tracks.root -o odd_gen2_material -m odd_gen2_material_mapsand for Gen2:
python ~/Documents/work/dev/acts-grid-material-prs/Examples/Scripts/Python/material_mapping_core.py -i geant4_material_tracks.root -o odd_gen2_material -m odd_gen2_material_maps --experimental