feat: example material mapping using new core mapper (MM5) #3094
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
Component - Core
asalzburger
added
🛑 blocked
github-actions
bot
added
Component - Core
📊: Physics performance monitoring for cd41255physmon summary
|
|
Hi @Corentin-Allaire - this is the next one, it does not yet set up the logic of pre-sensor / post-sensor mapping, but it looks quite ok as a first shot. |
|
ping @Corentin-Allaire |
Corentin-Allaire
approved these changes
Apr 16, 2024
🔴 Athena integration test results [a54444f]🔴 Some tests have failed!Please investigate the pipeline! |
acts-project-service
added
the
Fails Athena tests
Ragansu
pushed a commit
to Ragansu/acts
that referenced
this pull request
Apr 19, 2024
…ect#3094) This re-establishes the vanilla material mapping using the new Core modules and a very simple `CoreMaterialMapping` algorithm (this one will be kept until the full functionality is reinstalled). For out-of-the-box validation this is already quite good: 
kodiakhq bot
pushed a commit
that referenced
this pull request
May 1, 2024
This PR introduces (optimally navigation-less) material validation using core components. It agrees very with the propagation based one, see below:  This PR now enables full support for `BinnedSurfaceMaterial` and `HomogeneousSurfaceMaterial` for Gen1 and Gen2 geometry. While #3094 and #3109 enabled the creation of `.json` and `.root` maps from both Gen1 and Gen2 material, this one allows to test them. E.g. for the ODD: *Gen1 geometry:* ```sh python ~/Documents/work/dev/acts-grid-material-prs/Examples/Scripts/Python/material_validation_core.py -o odd_gen1_material_validation_root -n 1000 -t 1000 -m odd_gen1_material_maps.root ``` *Gen2 geometry:* ```sh python ~/Documents/work/dev/acts-grid-material-prs/Examples/Scripts/Python/material_validation_core.py -o odd_gen2_material_validation_root -n 1000 -t 1000 -m odd_gen2_material_maps.root --experimental ```
EleniXoch
pushed a commit
to EleniXoch/acts
that referenced
this pull request
May 6, 2024
…ect#3094) This re-establishes the vanilla material mapping using the new Core modules and a very simple `CoreMaterialMapping` algorithm (this one will be kept until the full functionality is reinstalled). For out-of-the-box validation this is already quite good: 
EleniXoch
pushed a commit
to EleniXoch/acts
that referenced
this pull request
May 6, 2024
) This PR introduces (optimally navigation-less) material validation using core components. It agrees very with the propagation based one, see below:  This PR now enables full support for `BinnedSurfaceMaterial` and `HomogeneousSurfaceMaterial` for Gen1 and Gen2 geometry. While acts-project#3094 and acts-project#3109 enabled the creation of `.json` and `.root` maps from both Gen1 and Gen2 material, this one allows to test them. E.g. for the ODD: *Gen1 geometry:* ```sh python ~/Documents/work/dev/acts-grid-material-prs/Examples/Scripts/Python/material_validation_core.py -o odd_gen1_material_validation_root -n 1000 -t 1000 -m odd_gen1_material_maps.root ``` *Gen2 geometry:* ```sh python ~/Documents/work/dev/acts-grid-material-prs/Examples/Scripts/Python/material_validation_core.py -o odd_gen2_material_validation_root -n 1000 -t 1000 -m odd_gen2_material_maps.root --experimental ```
asalzburger
added a commit
to asalzburger/acts
that referenced
this pull request
May 21, 2024
…ect#3094) This re-establishes the vanilla material mapping using the new Core modules and a very simple `CoreMaterialMapping` algorithm (this one will be kept until the full functionality is reinstalled). For out-of-the-box validation this is already quite good: 
asalzburger
added a commit
to asalzburger/acts
that referenced
this pull request
May 21, 2024
) This PR introduces (optimally navigation-less) material validation using core components. It agrees very with the propagation based one, see below:  This PR now enables full support for `BinnedSurfaceMaterial` and `HomogeneousSurfaceMaterial` for Gen1 and Gen2 geometry. While acts-project#3094 and acts-project#3109 enabled the creation of `.json` and `.root` maps from both Gen1 and Gen2 material, this one allows to test them. E.g. for the ODD: *Gen1 geometry:* ```sh python ~/Documents/work/dev/acts-grid-material-prs/Examples/Scripts/Python/material_validation_core.py -o odd_gen1_material_validation_root -n 1000 -t 1000 -m odd_gen1_material_maps.root ``` *Gen2 geometry:* ```sh python ~/Documents/work/dev/acts-grid-material-prs/Examples/Scripts/Python/material_validation_core.py -o odd_gen2_material_validation_root -n 1000 -t 1000 -m odd_gen2_material_maps.root --experimental ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This re-establishes the vanilla material mapping using the new Core modules and a very simple
CoreMaterialMappingalgorithm (this one will be kept until the full functionality is reinstalled).For out-of-the-box validation this is already quite good: