refactor: TrackingVolume and VolumeBounds mutability #3037
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
Component - Core
paulgessinger
force-pushed
the
refactor/geometry/1/tracking-volume-bounds-mutability
branch
from
440b67d
to
3e86207
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3037 +/- ##
==========================================
+ Coverage 48.81% 48.91% +0.09%
==========================================
Files 489 488 -1
Lines 28883 28896 +13
Branches 13711 13708 -3
==========================================
+ Hits 14099 14134 +35
+ Misses 4955 4947 -8
+ Partials 9829 9815 -14 ☔ View full report in Codecov by Sentry. |
📊: Physics performance monitoring for c9c7d47physmon summary
|
paulgessinger
force-pushed
the
refactor/geometry/1/tracking-volume-bounds-mutability
branch
from
c9c7d47
to
3cde124
Compare
github-actions
bot
removed
the
Component - Documentation
acts-project-service
added
the
Breaks Athena build
EleniXoch
pushed a commit
to EleniXoch/acts
that referenced
this pull request
May 6, 2024
This PR: - Updates the `TrackingVolume.cpp` files, moving some methods - `TrackingVolume` holds mother volume as mutable - `CuboidVolumeBounds` and `CylinderVolumeBounds`: - Produce their boundary surfaces when requested instead of ahead of time - Gain `set()` functions to modify their defining parameters (used for volume synchronization) - `Volume` holds `VolumeBounds` as mutable internally, propagates mutability correctly (allows mutating non-const `Volume` instances) - Removes the `TrackingVolume::create` factories (they don't really have a reason at this point) Blocked by: - acts-project#3026 - acts-project#3030 - acts-project#3032 - acts-project#3031
asalzburger
pushed a commit
to asalzburger/acts
that referenced
this pull request
May 21, 2024
This PR: - Updates the `TrackingVolume.cpp` files, moving some methods - `TrackingVolume` holds mother volume as mutable - `CuboidVolumeBounds` and `CylinderVolumeBounds`: - Produce their boundary surfaces when requested instead of ahead of time - Gain `set()` functions to modify their defining parameters (used for volume synchronization) - `Volume` holds `VolumeBounds` as mutable internally, propagates mutability correctly (allows mutating non-const `Volume` instances) - Removes the `TrackingVolume::create` factories (they don't really have a reason at this point) Blocked by: - acts-project#3026 - acts-project#3030 - acts-project#3032 - acts-project#3031
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR:
TrackingVolume.cppfiles, moving some methodsTrackingVolumeholds mother volume as mutableCuboidVolumeBoundsandCylinderVolumeBounds:set()functions to modify their defining parameters (used for volume synchronization)VolumeholdsVolumeBoundsas mutable internally, propagates mutability correctly (allows mutating non-constVolumeinstances)TrackingVolume::createfactories (they don't really have a reason at this point)Blocked by: