refactor: OrientedSurface improvements #3026
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
Component - Core
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3026 +/- ##
==========================================
+ Coverage 48.82% 48.83% +0.01%
==========================================
Files 491 491
Lines 28886 28893 +7
Branches 13705 13705
==========================================
+ Hits 14104 14111 +7
Misses 4954 4954
Partials 9828 9828 ☔ View full report in Codecov by Sentry. |
📊: Physics performance monitoring for 1cdb6fephysmon summary
|
andiwand
reviewed
Mar 13, 2024
|
@andiwand Thanks, somehow I missed these. |
Co-authored-by: Andreas Stefl <[email protected]>
Co-authored-by: Andreas Stefl <[email protected]>
paulgessinger
force-pushed
the
refactor/geometry/orientedsurfaces
branch
from
8352817
to
1cdb6fe
Compare
andiwand
approved these changes
Mar 15, 2024
dimitra97
pushed a commit
to dimitra97/acts
that referenced
this pull request
Mar 19, 2024
This PR: 1. Makes `OrientedSurface` a struct with member names 2. Remove the `OrientedSurfaces` typedef over a vector 3. Add aliases `AlongNormal` and `OppositeNormal` to the `Direction` type I don't think this is breaking.
kodiakhq bot
pushed a commit
that referenced
this pull request
Mar 25, 2024
This PR: - Updates the `TrackingVolume.cpp` files, moving some methods - `TrackingVolume` holds mother volume as mutable - `CuboidVolumeBounds` and `CylinderVolumeBounds`: - Produce their boundary surfaces when requested instead of ahead of time - Gain `set()` functions to modify their defining parameters (used for volume synchronization) - `Volume` holds `VolumeBounds` as mutable internally, propagates mutability correctly (allows mutating non-const `Volume` instances) - Removes the `TrackingVolume::create` factories (they don't really have a reason at this point) Blocked by: - #3026 - #3030 - #3032 - #3031
EleniXoch
pushed a commit
to EleniXoch/acts
that referenced
this pull request
May 6, 2024
This PR: 1. Makes `OrientedSurface` a struct with member names 2. Remove the `OrientedSurfaces` typedef over a vector 3. Add aliases `AlongNormal` and `OppositeNormal` to the `Direction` type I don't think this is breaking.
EleniXoch
pushed a commit
to EleniXoch/acts
that referenced
this pull request
May 6, 2024
This PR: - Updates the `TrackingVolume.cpp` files, moving some methods - `TrackingVolume` holds mother volume as mutable - `CuboidVolumeBounds` and `CylinderVolumeBounds`: - Produce their boundary surfaces when requested instead of ahead of time - Gain `set()` functions to modify their defining parameters (used for volume synchronization) - `Volume` holds `VolumeBounds` as mutable internally, propagates mutability correctly (allows mutating non-const `Volume` instances) - Removes the `TrackingVolume::create` factories (they don't really have a reason at this point) Blocked by: - acts-project#3026 - acts-project#3030 - acts-project#3032 - acts-project#3031
asalzburger
pushed a commit
to asalzburger/acts
that referenced
this pull request
May 21, 2024
This PR: 1. Makes `OrientedSurface` a struct with member names 2. Remove the `OrientedSurfaces` typedef over a vector 3. Add aliases `AlongNormal` and `OppositeNormal` to the `Direction` type I don't think this is breaking.
asalzburger
pushed a commit
to asalzburger/acts
that referenced
this pull request
May 21, 2024
This PR: - Updates the `TrackingVolume.cpp` files, moving some methods - `TrackingVolume` holds mother volume as mutable - `CuboidVolumeBounds` and `CylinderVolumeBounds`: - Produce their boundary surfaces when requested instead of ahead of time - Gain `set()` functions to modify their defining parameters (used for volume synchronization) - `Volume` holds `VolumeBounds` as mutable internally, propagates mutability correctly (allows mutating non-const `Volume` instances) - Removes the `TrackingVolume::create` factories (they don't really have a reason at this point) Blocked by: - acts-project#3026 - acts-project#3030 - acts-project#3032 - acts-project#3031
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR:
OrientedSurfacea struct with member namesOrientedSurfacestypedef over a vectorAlongNormalandOppositeNormalto theDirectiontypeI don't think this is breaking.