Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Wire optional seed result in TrackDensityVertexFinder after #2917 #3002

Merged

Merge branch 'main' into fix-trackdensityvertexfinder-after-2917

8e1ac39
Select commit
Loading
Failed to load commit list.
Merged

fix: Wire optional seed result in TrackDensityVertexFinder after #2917 #3002

Merge branch 'main' into fix-trackdensityvertexfinder-after-2917
8e1ac39
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Mar 1, 2024 in 1s

48.69% (-0.01%) compared to 3d96535

View this Pull Request on Codecov

48.69% (-0.01%) compared to 3d96535

Details

Codecov Report

Attention: Patch coverage is 40.00000% with 12 lines in your changes are missing coverage. Please review.

Project coverage is 48.69%. Comparing base (3d96535) to head (8e1ac39).

Files Patch % Lines
Core/src/Vertexing/GaussianTrackDensity.cpp 30.76% 9 Missing ⚠️
Core/src/Vertexing/TrackDensityVertexFinder.cpp 57.14% 1 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3002      +/-   ##
==========================================
- Coverage   48.69%   48.69%   -0.01%     
==========================================
  Files         493      493              
  Lines       28980    28991      +11     
  Branches    13800    13803       +3     
==========================================
+ Hits        14112    14117       +5     
- Misses       4939     4946       +7     
+ Partials     9929     9928       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.