fix: Wire optional seed result in TrackDensityVertexFinder after #2917

[andiwand]

In #2917 I changed the way how "no more seeds" is communicated in our vertexing code but forgot to wire this for the TrackDensityVertexFinder correctly.

[acts-project-service]

✅ Athena integration test results [abdddc6]

✅ All tests successful

status	job	report
🟢	run_unit_tests
🟢	test_ActsEFTrackFit
🟢	test_ActsBenchmarkWithSpot
🟢	test_ActsConversionWorkflow
🟢	test_ActsWorkflow
🟢	test_ActsValidateAmbiguityResolution
🟢	test_ActsValidateResolvedTracks
🟢	test_ActsValidateTracks
🟢	test_ActsValidateActsCoreSpacePoints
🟢	test_ActsValidateActsSpacePoints
🟢	test_ActsValidateSeeds
🟢	test_ActsValidateOrthogonalSeeds
🟢	test_ActsValidateClusters
🟢	test_ActsPersistifyEDM
🟢	test_ActsGSFRefitting
🟢	test_ActsKfRefitting
🟢	test_ActsExtrapolationAlgTest
🟢	test_ActsITkTest
🟢	run_workflow_tests_run4_mc
🟢	run_workflow_tests_run2_mc
🟢	run_workflow_tests_run2_data
🟢	run_workflow_tests_run3_mc
🟢	run_workflow_tests_run3_data
🟢	run_art_test: test_data18_13TeV_1000evt
🟢	run_art_test: test_ttbarPU40_reco

[codecov]

Codecov Report

Attention: Patch coverage is 40.00000% with 12 lines in your changes are missing coverage. Please review.

Project coverage is 48.69%. Comparing base (3d96535) to head (8e1ac39).

Files	Patch %	Lines
Core/src/Vertexing/GaussianTrackDensity.cpp	30.76%	9 Missing ⚠️
Core/src/Vertexing/TrackDensityVertexFinder.cpp	57.14%	1 Missing and 2 partials ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #3002      +/-   ##
==========================================
- Coverage   48.69%   48.69%   -0.01%     
==========================================
  Files         493      493              
  Lines       28980    28991      +11     
  Branches    13800    13803       +3     
==========================================
+ Hits        14112    14117       +5     
- Misses       4939     4946       +7     
+ Partials     9929     9928       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[github-actions]

📊: Physics performance monitoring for 8e1ac39

Full contents

physmon summary

• ✅ CKF truth_smeared
• ✅ IVF truth_smeared
• ✅ AMVF truth_smeared
• ✅ Track Summary CKF truth_smeared
• ✅ Seeding truth_estimated
• ✅ CKF truth_estimated
• ✅ IVF truth_estimated
• ✅ AMVF truth_estimated
• ✅ Track Summary CKF truth_estimated
• ✅ Seeding seeded
• ✅ CKF seeded
• ✅ IVF seeded
• ✅ AMVF seeded
• ✅ AMVF (+grid seeder) seeded
• ✅ Track Summary CKF seeded
• ✅ Seeding orthogonal
• ✅ CKF orthogonal
• ✅ IVF orthogonal
• ✅ AMVF orthogonal
• ✅ Track Summary CKF orthogonal
• ✅ Ambisolver seeded
• ✅ Ambisolver orthogonal
• ✅ Seeding ttbar
• ✅ CKF ttbar
• ✅ Ambisolver
• ✅ Track Summary CKF ttbar
• ✅ AMVF ttbar
• ✅ AMVF (+grid seeder) ttbar
• ✅ Truth tracking (GSF)
• ✅ Truth tracking
• ✅ Truth tracking (GX2F)
• ✅ Particles fatras
• ✅ Particles geant4

[paulgessinger]

I think the output failures indicate that we're going back to the original outputs. I'd be inclined to either merge this and then manually remove the reference overrides (thus going back to the vanilla references active in Athena main) or doing that before merging and triggering here again. In any case, it's a bit of a manually timed operation.

[andiwand]

I think the output failures indicate that we're going back to the original outputs. I'd be inclined to either merge this and then manually remove the reference overrides (thus going back to the vanilla references active in Athena main) or doing that before merging and triggering here again. In any case, it's a bit of a manually timed operation.

What suits better for you? From my side both is fine. If you revert the output changes we can just make this PR the next to go in

[paulgessinger]

Retriggered now with the reference override from before #2917. There were also two failure just due to connection issues, I believe.

[paulgessinger]

Let's go!