-
Notifications
You must be signed in to change notification settings - Fork 168
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor!: Move and Grid Density finders to cpp #2973
refactor!: Move and Grid Density finders to cpp #2973
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2973 +/- ##
==========================================
- Coverage 48.72% 48.70% -0.03%
==========================================
Files 493 493
Lines 28968 28976 +8
Branches 13790 13798 +8
==========================================
- Hits 14114 14112 -2
- Misses 4930 4935 +5
- Partials 9924 9929 +5 ☔ View full report in Codecov by Sentry. |
📊: Physics performance monitoring for ffac673physmon summary
|
1fdd342
to
7216275
Compare
7216275
to
7ea5362
Compare
Now this has some changes that we might want to discuss @andiwand: The grid size becomes a runtime parameter, which is taken from the configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
making this is runtime config makes total sense to me. no clue why this was a template parameter in the first place
Should be ready @andiwand. |
This PR moves - `GaussianGridTrackDensity` - `GridDensityVertexFinder` to cpp files. It has to refactor the interface a bit to make this possible, mostly, the grid sizes become runtime arguments instead of compile-time parameters. This then also changes the internal grid eigen objects to be dynamic, which I think should be fine because we essentially only do lookups on them. Part of: - acts-project#2842 Blocked by: - acts-project#2971
This PR moves - `GaussianGridTrackDensity` - `GridDensityVertexFinder` to cpp files. It has to refactor the interface a bit to make this possible, mostly, the grid sizes become runtime arguments instead of compile-time parameters. This then also changes the internal grid eigen objects to be dynamic, which I think should be fine because we essentially only do lookups on them. Part of: - acts-project#2842 Blocked by: - acts-project#2971
This PR moves
GaussianGridTrackDensity
GridDensityVertexFinder
to cpp files. It has to refactor the interface a bit to make this possible, mostly, the grid sizes become runtime arguments instead of compile-time parameters. This then also changes the internal grid eigen objects to be dynamic, which I think should be fine because we essentially only do lookups on them.
Part of:
Blocked by:
ImpactPointEstimator
moves to cpp file #2971