refactor!: ImpactPointEstimator moves to cpp file
#2971
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2971 +/- ##
==========================================
- Coverage 48.73% 48.72% -0.02%
==========================================
Files 493 493
Lines 28943 28968 +25
Branches 13776 13790 +14
==========================================
+ Hits 14106 14114 +8
- Misses 4924 4930 +6
- Partials 9913 9924 +11 ☔ View full report in Codecov by Sentry. |
📊: Physics performance monitoring for 630e743physmon summary
|
paulgessinger
force-pushed
the
refactor/vtx-templates-part11-ipest-cpp
branch
from
ab77ef0
to
9c485e6
Compare
paulgessinger
force-pushed
the
refactor/vtx-templates-part11-ipest-cpp
branch
from
9c485e6
to
8e23310
Compare
andiwand
previously approved these changes
Feb 27, 2024
andiwand
approved these changes
Feb 27, 2024
acts-project-service
added
the
Breaks Athena build
kodiakhq bot
pushed a commit
that referenced
this pull request
Feb 28, 2024
This PR moves - `GaussianGridTrackDensity` - `GridDensityVertexFinder` to cpp files. It has to refactor the interface a bit to make this possible, mostly, the grid sizes become runtime arguments instead of compile-time parameters. This then also changes the internal grid eigen objects to be dynamic, which I think should be fine because we essentially only do lookups on them. Part of: - #2842 Blocked by: - #2971
EleniXoch
pushed a commit
to EleniXoch/acts
that referenced
this pull request
May 6, 2024
This PR moves the code of the `ImpactPointEstimator` from the header into a compiled file. To allow this, I have to make some changes to the interface to remove templates. In the process, I introduced `Eigen::Map<ActsDynamicVector>` as an argument to `getDistanceAndMomentum` and `getVertexCompatibility`. Part of: - acts-project#2842 Blocked by: - acts-project#2953
EleniXoch
pushed a commit
to EleniXoch/acts
that referenced
this pull request
May 6, 2024
This PR moves - `GaussianGridTrackDensity` - `GridDensityVertexFinder` to cpp files. It has to refactor the interface a bit to make this possible, mostly, the grid sizes become runtime arguments instead of compile-time parameters. This then also changes the internal grid eigen objects to be dynamic, which I think should be fine because we essentially only do lookups on them. Part of: - acts-project#2842 Blocked by: - acts-project#2971
asalzburger
pushed a commit
to asalzburger/acts
that referenced
this pull request
May 21, 2024
This PR moves the code of the `ImpactPointEstimator` from the header into a compiled file. To allow this, I have to make some changes to the interface to remove templates. In the process, I introduced `Eigen::Map<ActsDynamicVector>` as an argument to `getDistanceAndMomentum` and `getVertexCompatibility`. Part of: - acts-project#2842 Blocked by: - acts-project#2953
asalzburger
pushed a commit
to asalzburger/acts
that referenced
this pull request
May 21, 2024
This PR moves - `GaussianGridTrackDensity` - `GridDensityVertexFinder` to cpp files. It has to refactor the interface a bit to make this possible, mostly, the grid sizes become runtime arguments instead of compile-time parameters. This then also changes the internal grid eigen objects to be dynamic, which I think should be fine because we essentially only do lookups on them. Part of: - acts-project#2842 Blocked by: - acts-project#2971
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR moves the code of the
ImpactPointEstimatorfrom the header into a compiled file. To allow this, I have to make some changes to the interface to remove templates.In the process, I introduced
Eigen::Map<ActsDynamicVector>as an argument togetDistanceAndMomentumandgetVertexCompatibility.Part of:
Blocked by:
.cppfiles #2953