refactor!: Refactor Surface::boundToFreeJacobian to use free instead of bound vector
#2811
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s into refactor-surface-bound-to-free
github-actions
bot
added
Component - Core
📊: Physics performance monitoring for 5cfc202physmon summary
|
acts-project-service
added
the
Breaks Athena build
…ctor-surface-bound-to-free
|
I hope this does not break Athena anymore |
AJPfleger
reviewed
Mar 28, 2024
Co-authored-by: Alexander J. Pfleger <[email protected]>
This reverts commit efb3ad0.
This reverts commit def02d5.
AJPfleger
approved these changes
Mar 28, 2024
kodiakhq bot
pushed a commit
that referenced
this pull request
Apr 9, 2024
I noticed that the concept of a curvilinear surface is a quite spread over the codebase and I wanted to improve this. Here I introduce a surface like class which does not actually inherit from `Acts::Surface` but shares some of the functionality. This way the jacobians are put in a single place and can be used from somewhere else in an expressive fashion. Afterwards it might make sense to let the `CurvilinearTrackParameters` depend on this special surface instead of a `PlaneSurface` or to merge them with `BoundTrackParameters` completely. related issues - #2812 blocked by - #2789 - #2782 - #2781 - #2811
Ragansu
pushed a commit
to Ragansu/acts
that referenced
this pull request
Apr 19, 2024
…ection (acts-project#2933) We do not depend on free parameters for `Surface` so this should not be part of the interface. I consistently replace this by position and direction vectors here. blocked by - acts-project#2932 - acts-project#2811
Ragansu
pushed a commit
to Ragansu/acts
that referenced
this pull request
Apr 19, 2024
I noticed that the concept of a curvilinear surface is a quite spread over the codebase and I wanted to improve this. Here I introduce a surface like class which does not actually inherit from `Acts::Surface` but shares some of the functionality. This way the jacobians are put in a single place and can be used from somewhere else in an expressive fashion. Afterwards it might make sense to let the `CurvilinearTrackParameters` depend on this special surface instead of a `PlaneSurface` or to merge them with `BoundTrackParameters` completely. related issues - acts-project#2812 blocked by - acts-project#2789 - acts-project#2782 - acts-project#2781 - acts-project#2811
EleniXoch
pushed a commit
to EleniXoch/acts
that referenced
this pull request
May 6, 2024
…aram input (acts-project#2932) This popped up in acts-project#2811 - as this can be a pitfall we are asserting if we are really on surface. This is done via an `assert` which is not evaluated in standard release build This also fixes a bug in the covariance engine. We used to first do the cov transport and then check if we are actually on surface. I turned these checks around.
EleniXoch
pushed a commit
to EleniXoch/acts
that referenced
this pull request
May 6, 2024
…d of bound vector (acts-project#2811) This avoid free->bound->free roundtrips and aligns the interface with `freeToBoundJacobian` related issues - acts-project#2810 blocked by - acts-project#2789 - acts-project#2782 - acts-project#2781
EleniXoch
pushed a commit
to EleniXoch/acts
that referenced
this pull request
May 6, 2024
…ection (acts-project#2933) We do not depend on free parameters for `Surface` so this should not be part of the interface. I consistently replace this by position and direction vectors here. blocked by - acts-project#2932 - acts-project#2811
EleniXoch
pushed a commit
to EleniXoch/acts
that referenced
this pull request
May 6, 2024
I noticed that the concept of a curvilinear surface is a quite spread over the codebase and I wanted to improve this. Here I introduce a surface like class which does not actually inherit from `Acts::Surface` but shares some of the functionality. This way the jacobians are put in a single place and can be used from somewhere else in an expressive fashion. Afterwards it might make sense to let the `CurvilinearTrackParameters` depend on this special surface instead of a `PlaneSurface` or to merge them with `BoundTrackParameters` completely. related issues - acts-project#2812 blocked by - acts-project#2789 - acts-project#2782 - acts-project#2781 - acts-project#2811
asalzburger
pushed a commit
to asalzburger/acts
that referenced
this pull request
May 21, 2024
…aram input (acts-project#2932) This popped up in acts-project#2811 - as this can be a pitfall we are asserting if we are really on surface. This is done via an `assert` which is not evaluated in standard release build This also fixes a bug in the covariance engine. We used to first do the cov transport and then check if we are actually on surface. I turned these checks around.
asalzburger
pushed a commit
to asalzburger/acts
that referenced
this pull request
May 21, 2024
…d of bound vector (acts-project#2811) This avoid free->bound->free roundtrips and aligns the interface with `freeToBoundJacobian` related issues - acts-project#2810 blocked by - acts-project#2789 - acts-project#2782 - acts-project#2781
asalzburger
pushed a commit
to asalzburger/acts
that referenced
this pull request
May 21, 2024
…ection (acts-project#2933) We do not depend on free parameters for `Surface` so this should not be part of the interface. I consistently replace this by position and direction vectors here. blocked by - acts-project#2932 - acts-project#2811
asalzburger
pushed a commit
to asalzburger/acts
that referenced
this pull request
May 21, 2024
I noticed that the concept of a curvilinear surface is a quite spread over the codebase and I wanted to improve this. Here I introduce a surface like class which does not actually inherit from `Acts::Surface` but shares some of the functionality. This way the jacobians are put in a single place and can be used from somewhere else in an expressive fashion. Afterwards it might make sense to let the `CurvilinearTrackParameters` depend on this special surface instead of a `PlaneSurface` or to merge them with `BoundTrackParameters` completely. related issues - acts-project#2812 blocked by - acts-project#2789 - acts-project#2782 - acts-project#2781 - acts-project#2811
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This avoid free->bound->free roundtrips and aligns the interface with
freeToBoundJacobianrelated issues
Surface::boundToFreeJacobiancould also useFreeVectorparameters #2810blocked by
JacobianEngine#2789CovarianceTransport#2781