refactor: Reuse JacobianEngine
#2789
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
Component - Core
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #2789 +/- ##
==========================================
+ Coverage 48.97% 49.03% +0.06%
==========================================
Files 492 492
Lines 28593 28526 -67
Branches 13524 13477 -47
==========================================
- Hits 14004 13989 -15
+ Misses 4825 4819 -6
+ Partials 9764 9718 -46 ☔ View full report in Codecov by Sentry. |
📊: Physics performance monitoring for c9a6ed3physmon summary
|
This was referenced Dec 12, 2023
acts-project-service
added
the
Breaks Athena build
|
This breaks Athena compilation. I guess technically, since this is in detail, we would not call it a breaking change, but de-facto it seems to be used publicly. Maybe this indicates we need to move this OUT of detail, and hence mark this breaking? |
Co-authored-by: Paul Gessinger <[email protected]>
puh that is unexpected. I was hoping that this is not used outside. do you know where it is used and how extensively? |
paulgessinger
approved these changes
Jan 18, 2024
LaraCalic
pushed a commit
to LaraCalic/acts
that referenced
this pull request
Feb 10, 2024
In acts-project#2780 I realized that we do not call any of the functions in `JacobianEngine` on the current main branch and most of them are duplicated in `CovarianceEngine`. Here I try to unify the duplicated code again blocked by - acts-project#2782 - acts-project#2781
kodiakhq bot
pushed a commit
that referenced
this pull request
Apr 9, 2024
I noticed that the concept of a curvilinear surface is a quite spread over the codebase and I wanted to improve this. Here I introduce a surface like class which does not actually inherit from `Acts::Surface` but shares some of the functionality. This way the jacobians are put in a single place and can be used from somewhere else in an expressive fashion. Afterwards it might make sense to let the `CurvilinearTrackParameters` depend on this special surface instead of a `PlaneSurface` or to merge them with `BoundTrackParameters` completely. related issues - #2812 blocked by - #2789 - #2782 - #2781 - #2811
Ragansu
pushed a commit
to Ragansu/acts
that referenced
this pull request
Apr 19, 2024
I noticed that the concept of a curvilinear surface is a quite spread over the codebase and I wanted to improve this. Here I introduce a surface like class which does not actually inherit from `Acts::Surface` but shares some of the functionality. This way the jacobians are put in a single place and can be used from somewhere else in an expressive fashion. Afterwards it might make sense to let the `CurvilinearTrackParameters` depend on this special surface instead of a `PlaneSurface` or to merge them with `BoundTrackParameters` completely. related issues - acts-project#2812 blocked by - acts-project#2789 - acts-project#2782 - acts-project#2781 - acts-project#2811
EleniXoch
pushed a commit
to EleniXoch/acts
that referenced
this pull request
May 6, 2024
…d of bound vector (acts-project#2811) This avoid free->bound->free roundtrips and aligns the interface with `freeToBoundJacobian` related issues - acts-project#2810 blocked by - acts-project#2789 - acts-project#2782 - acts-project#2781
EleniXoch
pushed a commit
to EleniXoch/acts
that referenced
this pull request
May 6, 2024
I noticed that the concept of a curvilinear surface is a quite spread over the codebase and I wanted to improve this. Here I introduce a surface like class which does not actually inherit from `Acts::Surface` but shares some of the functionality. This way the jacobians are put in a single place and can be used from somewhere else in an expressive fashion. Afterwards it might make sense to let the `CurvilinearTrackParameters` depend on this special surface instead of a `PlaneSurface` or to merge them with `BoundTrackParameters` completely. related issues - acts-project#2812 blocked by - acts-project#2789 - acts-project#2782 - acts-project#2781 - acts-project#2811
asalzburger
pushed a commit
to asalzburger/acts
that referenced
this pull request
May 21, 2024
…d of bound vector (acts-project#2811) This avoid free->bound->free roundtrips and aligns the interface with `freeToBoundJacobian` related issues - acts-project#2810 blocked by - acts-project#2789 - acts-project#2782 - acts-project#2781
asalzburger
pushed a commit
to asalzburger/acts
that referenced
this pull request
May 21, 2024
I noticed that the concept of a curvilinear surface is a quite spread over the codebase and I wanted to improve this. Here I introduce a surface like class which does not actually inherit from `Acts::Surface` but shares some of the functionality. This way the jacobians are put in a single place and can be used from somewhere else in an expressive fashion. Afterwards it might make sense to let the `CurvilinearTrackParameters` depend on this special surface instead of a `PlaneSurface` or to merge them with `BoundTrackParameters` completely. related issues - acts-project#2812 blocked by - acts-project#2789 - acts-project#2782 - acts-project#2781 - acts-project#2811
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #2780 I realized that we do not call any of the functions in
JacobianEngineon the current main branch and most of them are duplicated inCovarianceEngine. Here I try to unify the duplicated code againblocked by
CovarianceTransport#2781