-
Notifications
You must be signed in to change notification settings - Fork 168
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: dd4hep surface factory #2501
feat: dd4hep surface factory #2501
Conversation
Codecov Report
@@ Coverage Diff @@
## main #2501 +/- ##
=======================================
Coverage 49.79% 49.79%
=======================================
Files 466 466
Lines 26262 26262
Branches 12063 12063
=======================================
Hits 13076 13076
Misses 4613 4613
Partials 8573 8573 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks good. Approving!
There are a few clang-tidy complaints remaining. |
Invalidated by push of c474604
I am on it, also I had a doc build failure, let's check. |
@dimitra97 can you reapprove, please? The clang-tidy change invalidated your approval. |
This is the next step in preparing the ODD chain for old and new detector.
It adds the new DD4hep surface factory and first set of unit tests.
@dimitra97 since you start to have DD4hep experience, I requested your review.