Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: dd4hep surface factory #2501

Conversation

asalzburger
Copy link
Contributor

This is the next step in preparing the ODD chain for old and new detector.
It adds the new DD4hep surface factory and first set of unit tests.

@dimitra97 since you start to have DD4hep experience, I requested your review.

@asalzburger asalzburger added this to the next milestone Oct 3, 2023
@asalzburger asalzburger changed the title feat: dd4hep pr2 dd4hep surface factory feat: dd4hep surface factory Oct 3, 2023
@github-actions github-actions bot added the Component - Plugins Affects one or more Plugins label Oct 3, 2023
@codecov
Copy link

codecov bot commented Oct 3, 2023

Codecov Report

Merging #2501 (c474604) into main (691f1d5) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #2501   +/-   ##
=======================================
  Coverage   49.79%   49.79%           
=======================================
  Files         466      466           
  Lines       26262    26262           
  Branches    12063    12063           
=======================================
  Hits        13076    13076           
  Misses       4613     4613           
  Partials     8573     8573           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

dimitra97
dimitra97 previously approved these changes Oct 4, 2023
Copy link
Contributor

@dimitra97 dimitra97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good. Approving!

@paulgessinger
Copy link
Member

There are a few clang-tidy complaints remaining.

@acts-policybot acts-policybot bot dismissed dimitra97’s stale review October 4, 2023 11:29

Invalidated by push of c474604

@asalzburger
Copy link
Contributor Author

There are a few clang-tidy complaints remaining.

I am on it, also I had a doc build failure, let's check.

@asalzburger
Copy link
Contributor Author

@dimitra97 can you reapprove, please?

The clang-tidy change invalidated your approval.

@asalzburger asalzburger merged commit a3013a0 into acts-project:main Oct 5, 2023
57 of 59 checks passed
@asalzburger asalzburger deleted the feat-dd4hep-pr2-dd4hep-surface-factory branch October 5, 2023 07:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component - Plugins Affects one or more Plugins
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants