Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: feat: check for unused files and restrict extensions #2678

Merged
merged 48 commits into from
Dec 1, 2023
Merged

ci: feat: check for unused files and restrict extensions #2678

merged 48 commits into from
Dec 1, 2023

Conversation

AJPfleger
Copy link
Contributor

@AJPfleger AJPfleger commented Nov 15, 2023 •
edited by andiwand
Loading

The new CI action checks if most of the files are referenced/included/used at some point.

Scripts-folders are excluded.

Removes files, that are not used (not referenced at any point).

For more recent files, I will ping the authors.

blocked by

@github-actions github-actions bot added Component - Core Affects the Core module Component - Examples Affects the Examples module Component - Plugins Affects one or more Plugins Seeding labels Nov 15, 2023
@codecov Codecov
Copy link

codecov bot commented Nov 15, 2023 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (c76e2c6) 49.51% compared to head (6a539e1) 49.51%.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #2678   +/-   ##
=======================================
  Coverage   49.51%   49.51%           
=======================================
  Files         474      474           
  Lines       27064    27064           
  Branches    12507    12507           
=======================================
  Hits        13401    13401           
  Misses       4761     4761           
  Partials     8902     8902

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 15, 2023 •
edited
Loading

📊: Physics performance monitoring for 6a539e1

Full contents

physmon summary

@github-actions github-actions bot added the Component - Documentation Affects the documentation label Nov 15, 2023
@github-actions github-actions bot removed Component - Core Affects the Core module Component - Plugins Affects one or more Plugins Seeding labels Nov 16, 2023
@github-actions github-actions bot added Component - Core Affects the Core module Component - Plugins Affects one or more Plugins Seeding labels Nov 16, 2023
@AJPfleger AJPfleger marked this pull request as ready for review November 18, 2023 00:02
@andiwand andiwand added this to the next milestone Nov 22, 2023
@andiwand andiwand added the 🛑 blocked This item is blocked by another item label Nov 22, 2023
@andiwand andiwand removed the 🛑 blocked This item is blocked by another item label Dec 1, 2023
@kodiakhq kodiakhq bot merged commit 81351f1 into acts-project:main Dec 1, 2023
52 checks passed
@github-actions github-actions bot removed the automerge label Dec 1, 2023
@AJPfleger AJPfleger deleted the unused branch December 1, 2023 11:32
@acts-project-service
Copy link
Collaborator

acts-project-service commented Dec 1, 2023 •
edited
Loading

✅ Athena integration test results

✅ All tests successful

status job
🟢 run_unit_tests
🟢 run_ci_tests: ../athena/AtlasTest/CITest/test/ActsBenchmarkWithSpot.sh 8 100
🟢 run_ci_tests: ../athena/AtlasTest/CITest/test/ActsWorkflow.sh
🟢 run_ci_tests: ../athena/AtlasTest/CITest/test/ActsValidateAmbiguityResolution.sh
🟢 run_ci_tests: ../athena/AtlasTest/CITest/test/ActsValidateResolvedTracks.sh
🟢 run_ci_tests: ../athena/AtlasTest/CITest/test/ActsValidateTracks.sh
🟢 run_ci_tests: ../athena/AtlasTest/CITest/test/ActsValidateActsCoreSpacePoints.sh
🟢 run_ci_tests: ../athena/AtlasTest/CITest/test/ActsValidateActsSpacePoints.sh
🟢 run_ci_tests: ../athena/AtlasTest/CITest/test/ActsValidateSeeds.sh
🟢 run_ci_tests: ../athena/AtlasTest/CITest/test/ActsValidateOrthogonalSeeds.sh
🟢 run_ci_tests: ../athena/AtlasTest/CITest/test/ActsValidateClusters.sh
🟢 run_ci_tests: ../athena/AtlasTest/CITest/test/ActsPersistifyEDM.sh
🟢 run_ci_tests: ../athena/AtlasTest/CITest/test/ActsGSFRefitting.sh
🟢 run_ci_tests: ../athena/AtlasTest/CITest/test/ActsKfRefitting.sh
🟢 run_ci_tests: python3 ../athena/Tracking/Acts/ActsGeometry/test/ActsExtrapolationAlgTest.py
🟢 run_ci_tests: python3 ../athena/Tracking/Acts/ActsGeometry/test/ActsITkTest.py
🟢 run_workflow_tests_run4_mc
🟢 run_workflow_tests_run2_data
🟢 run_workflow_tests_run3_mc
🟢 run_workflow_tests_run3_data

@acts-project-service acts-project-service added the Breaks Athena build This PR breaks the Athena build label Dec 4, 2023
asalzburger pushed a commit to asalzburger/acts that referenced this pull request Dec 6, 2023
@AJPfleger @asalzburger
ci: feat: check for unused files and restrict extensions (acts-projec…
7932743 
…t#2678)

The new CI action checks if most of the files are referenced/included/used at some point.

`Scripts`-folders are excluded.

Removes files, that are not used (not referenced at any point).

For more recent files, I will ping the authors.

blocked by
- acts-project#2700
@paulgessinger paulgessinger modified the milestones: next, v31.2.0 Dec 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dimitra97 dimitra97 dimitra97 left review comments

@benjaminhuth benjaminhuth benjaminhuth left review comments

@paulgessinger paulgessinger paulgessinger approved these changes

Assignees
No one assigned
Labels
Breaks Athena build This PR breaks the Athena build Component - Core Affects the Core module Component - Documentation Affects the documentation Component - Examples Affects the Examples module Component - Plugins Affects one or more Plugins Infrastructure Changes to build tools, continous integration, ... Seeding
Projects
None yet
Milestone
v31.2.0
Development

Successfully merging this pull request may close these issues.
6 participants
@AJPfleger @acts-project-service @paulgessinger @benjaminhuth @dimitra97 @andiwand