-
Notifications
You must be signed in to change notification settings - Fork 168
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: add important code forgotten in #2184 #2446
Merged
kodiakhq
merged 4 commits into
acts-project:main
from
benjaminhuth:fix/digitization-missing-code-why-dont-know-at-all
Sep 14, 2023
Merged
fix: add important code forgotten in #2184 #2446
kodiakhq
merged 4 commits into
acts-project:main
from
benjaminhuth:fix/digitization-missing-code-why-dont-know-at-all
Sep 14, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andiwand
previously approved these changes
Sep 13, 2023
Codecov Report
@@ Coverage Diff @@
## main #2446 +/- ##
=======================================
Coverage 49.71% 49.71%
=======================================
Files 461 461
Lines 25983 25983
Branches 11935 11935
=======================================
Hits 12917 12917
Misses 4598 4598
Partials 8468 8468 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
andiwand
approved these changes
Sep 14, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For reasons that are unkown to me, a very important part of #2184 is missing in main...