Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add important code forgotten in #2184 #2446

Conversation

benjaminhuth
Copy link
Member

For reasons that are unkown to me, a very important part of #2184 is missing in main...

@benjaminhuth benjaminhuth added this to the next milestone Sep 13, 2023
andiwand
andiwand previously approved these changes Sep 13, 2023
@github-actions github-actions bot added the Component - Examples Affects the Examples module label Sep 13, 2023
@codecov
Copy link

codecov bot commented Sep 13, 2023

Codecov Report

Merging #2446 (23c96a3) into main (f7e9f23) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #2446   +/-   ##
=======================================
  Coverage   49.71%   49.71%           
=======================================
  Files         461      461           
  Lines       25983    25983           
  Branches    11935    11935           
=======================================
  Hits        12917    12917           
  Misses       4598     4598           
  Partials     8468     8468           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Contributor

@andiwand andiwand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 👍

@kodiakhq kodiakhq bot merged commit 0c16c3f into acts-project:main Sep 14, 2023
56 checks passed
@paulgessinger paulgessinger modified the milestones: next, v29.2.0 Sep 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component - Examples Affects the Examples module
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants