feat: Step merger for Geant4 and digitization energy threshold #2184
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #2184 +/- ##
=======================================
Coverage 49.41% 49.41%
=======================================
Files 441 441
Lines 25176 25176
Branches 11617 11617
=======================================
Hits 12441 12441
Misses 4481 4481
Partials 8254 8254 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
📊 Physics performance monitoring for 2b2d32fSummary VertexingVertexing vs. muIVF seededIVF truth_smearedIVF truth_estimatedIVF orthogonalAMVF seededAMVF truth_smearedAMVF truth_estimatedAMVF orthogonalSeedingSeeding seededSeeding truth_estimatedSeeding orthogonalCKFCKF seededCKF truth_smearedCKF truth_estimatedCKF orthogonalAmbiguity resolutionseededTruth tracking (Kalman Filter)Truth trackingTruth tracking (GSF)Truth tracking |
benjaminhuth
added
Improvement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR does tow things:
Add a step merger to the Geant4 sim. This fixes the way how we record hits: Geant4 can do multiple steps through the material, which need to be combined to one single hit. Bevor, we recorded each step as hit.
Add a energy threshold for the hit acceptance to the digitization: This allows the digitization to reject hits with a very small energy deposit. The default value for this is
1000 * 3.65 eV(1000 electron-hole pairs for activation).Together, this reduces the all-over hits, that the
Geant4Simulationproduces on a ttbar event drastically. However, the number of "target hits" (hits of particles with pT > 500 MeV and nhits > 3 in this case) stays roughly the same.The energy threshold seems reasonable: In a particle-gun muon-only run in the ODD we see that almost all muons pass the threshold, but a lot low energy deposit electron hits are rejected by the digitization (energy deposit is negative, since it is stored as energy loss of the particle):