Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Generalise voidKalmanComponents #2394

Merged
merged 27 commits into from
Sep 4, 2023

Conversation

AJPfleger
Copy link
Contributor

@AJPfleger AJPfleger commented Aug 24, 2023

Since we are now using the voidKalmanComponents in KF, CKF, GSF, and GX2F we should generalise them. This removes a misleading dependency of the other fitters on the KF.

@codecov
Copy link

codecov bot commented Aug 24, 2023

Codecov Report

Merging #2394 (2532676) into main (6974f92) will not change coverage.
The diff coverage is 77.77%.

@@           Coverage Diff           @@
##             main    #2394   +/-   ##
=======================================
  Coverage   49.69%   49.69%           
=======================================
  Files         454      454           
  Lines       25809    25809           
  Branches    11852    11852           
=======================================
  Hits        12825    12825           
  Misses       4581     4581           
  Partials     8403     8403           
Files Changed Coverage Δ
.../Acts/TrackFitting/detail/VoidFitterComponents.hpp 26.66% <0.00%> (ø)
...de/Acts/TrackFinding/CombinatorialKalmanFilter.hpp 32.01% <100.00%> (ø)
...nclude/Acts/TrackFitting/GlobalChiSquareFitter.hpp 39.39% <100.00%> (ø)
Core/include/Acts/TrackFitting/GsfOptions.hpp 100.00% <100.00%> (ø)
Core/include/Acts/TrackFitting/KalmanFitter.hpp 43.22% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Member

@paulgessinger paulgessinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like it.

Is this breaking compatibility?

@paulgessinger paulgessinger added this to the next milestone Sep 1, 2023
@benjaminhuth
Copy link
Member

Actually, there's an inconsistency... The file is in the folder TrackFitting/detail, but the objects are in plain namespace Acts...
We should make this consistent...

@paulgessinger
Copy link
Member

@benjaminhuth In detail now, can you click the button?

@kodiakhq kodiakhq bot merged commit 07c292a into acts-project:main Sep 4, 2023
55 checks passed
@github-actions github-actions bot removed the automerge label Sep 4, 2023
@paulgessinger paulgessinger modified the milestones: next, v29.1.0 Sep 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants