-
Notifications
You must be signed in to change notification settings - Fork 168
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: Generalise voidKalmanComponents #2394
Conversation
Codecov Report
@@ Coverage Diff @@
## main #2394 +/- ##
=======================================
Coverage 49.69% 49.69%
=======================================
Files 454 454
Lines 25809 25809
Branches 11852 11852
=======================================
Hits 12825 12825
Misses 4581 4581
Partials 8403 8403
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like it.
Is this breaking compatibility?
Actually, there's an inconsistency... The file is in the folder |
@benjaminhuth In detail now, can you click the button? |
Since we are now using the
voidKalmanComponents
in KF, CKF, GSF, and GX2F we should generalise them. This removes a misleading dependency of the other fitters on the KF.