refactor!: Rename ActsSymMatrix -> ActsSquareMatrix

[felix-russo]

A square matrix has the same number of rows and columns.
A symmetric matrix is a square matrix with transposition symmetry, i.e., A.transpose() == A.

Since we don't impose transposition symmetry when initializing an ActsSymMatrix, I propose to rename it ActsSquareMatrix.

[codecov]

Codecov Report

Merging #2387 (95ffd44) into main (c3f99be) will decrease coverage by 0.01%.
The diff coverage is 22.44%.

@@            Coverage Diff             @@
##             main    #2387      +/-   ##
==========================================
- Coverage   49.70%   49.70%   -0.01%     
==========================================
  Files         452      452              
  Lines       25467    25468       +1     
  Branches    11650    11651       +1     
==========================================
  Hits        12658    12658              
  Misses       4578     4578              
- Partials     8231     8232       +1     

Files Changed	Coverage Δ
...ude/Acts/EventData/GenericBoundTrackParameters.hpp	67.10% <ø> (ø)
...ts/EventData/GenericCurvilinearTrackParameters.hpp	44.00% <ø> (ø)
...lude/Acts/EventData/GenericFreeTrackParameters.hpp	53.84% <ø> (ø)
Core/include/Acts/EventData/Measurement.hpp	80.00% <ø> (ø)
...s/EventData/MultiComponentBoundTrackParameters.hpp	61.81% <0.00%> (ø)
...Data/detail/CorrectedTransformationFreeToBound.hpp	100.00% <ø> (ø)
Core/include/Acts/Propagator/AtlasStepper.hpp	72.19% <0.00%> (ø)
...re/include/Acts/Propagator/CovarianceTransport.hpp	0.00% <ø> (ø)
Core/include/Acts/Propagator/EigenStepper.hpp	77.55% <0.00%> (ø)
Core/include/Acts/Propagator/EigenStepper.ipp	53.52% <ø> (ø)
... and 41 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

[benjaminhuth]

Good thing! 👍 I thought about this as well a lot of times, but was to lazy to make a PR...

[benjaminhuth]

Probably this should go into v29, right?

[github-actions]

📊: Physics performance monitoring for 95ffd44

Full contents

physmon summary

• ✅ CKF truth_smeared
• ✅ IVF truth_smeared
• ✅ AMVF truth_smeared
• ✅ Track Summary CKF truth_smeared
• ✅ Seeding truth_estimated
• ✅ CKF truth_estimated
• ✅ IVF truth_estimated
• ✅ AMVF truth_estimated
• ✅ Track Summary CKF truth_estimated
• ✅ Seeding seeded
• ✅ CKF seeded
• ✅ IVF seeded
• ✅ AMVF seeded
• ✅ AMVF (+grid seeder) seeded
• ✅ Track Summary CKF seeded
• ✅ Seeding orthogonal
• ✅ CKF orthogonal
• ✅ IVF orthogonal
• ✅ AMVF orthogonal
• ✅ Track Summary CKF orthogonal
• ✅ Ambisolver seeded
• ✅ Ambisolver orthogonal
• ✅ Seeding ttbar
• ✅ CKF ttbar
• ✅ Ambisolver
• ✅ AMVF ttbar
• ✅ AMVF (+grid seeder) ttbar
• ✅ Truth tracking (GSF)
• ✅ Truth tracking
• ✅ Particles inital fatras
• ✅ Particles final fatras
• ✅ Particles inital geant4
• ✅ Particles final geant4

[felix-russo]

Probably this should go into v29, right?

I would say so, yes!

[andiwand]

oh yeah that is very misleading. I think we already accumulated v29 changes on main so will apply automerge

[paulgessinger]

I'm going to guess that this will break a LOT of downstream code...

[andiwand]

if so we can try to split up the work of fixing Athena

[felix-russo]

I would help too of course!

[paulgessinger]

Mostly I think HUGE changes like this probably need to be announced / discussed in the meeting.

[benjaminhuth]

Hmm it is only huge in terms of linediff, but should be solvable by a single global find-replace operation... I believe most interface changes are more annoying to clients...
But sure, should be announced.

[paulgessinger]

I mean "huge" as in it breaks for almost everyone who's ever used ACTS.

[andiwand]

should we revert this then? better sooner than later as this will conflict a lot of branches

[benjaminhuth]

So my peronal opinion is not to revert it. Such changes are never painless, and I think its a good change since it expresses clearer what the type is