ci: Improve clang tidy job

[andiwand]

Improves the output and error handling of the clang tidy job.

Before the CI job did not print the output of the clang tidy calls and the error code was ignored.

[paulgessinger]

I think it did run most of the time, and only gets killed when running on a low-ish memory machine.

[codecov]

Codecov Report

Merging #2365 (a261f58) into main (b41968c) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #2365   +/-   ##
=======================================
  Coverage   49.60%   49.60%           
=======================================
  Files         452      452           
  Lines       25515    25515           
  Branches    11701    11701           
=======================================
  Hits        12656    12656           
  Misses       4579     4579           
  Partials     8280     8280           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

[github-actions]

📊: Physics performance monitoring for a261f58

Full contents

physmon summary

• ✅ CKF truth_smeared
• ✅ IVF truth_smeared
• ✅ AMVF truth_smeared
• ✅ Track Summary CKF truth_smeared
• ✅ Seeding truth_estimated
• ✅ CKF truth_estimated
• ✅ IVF truth_estimated
• ✅ AMVF truth_estimated
• ✅ Track Summary CKF truth_estimated
• ✅ Seeding seeded
• ✅ CKF seeded
• ✅ IVF seeded
• ✅ AMVF seeded
• ✅ AMVF (+grid seeder) seeded
• ✅ Track Summary CKF seeded
• ✅ Seeding orthogonal
• ✅ CKF orthogonal
• ✅ IVF orthogonal
• ✅ AMVF orthogonal
• ✅ Track Summary CKF orthogonal
• ✅ Ambisolver seeded
• ✅ Ambisolver orthogonal
• ✅ Seeding ttbar
• ✅ CKF ttbar
• ✅ Ambisolver
• ✅ AMVF ttbar
• ✅ AMVF (+grid seeder) ttbar
• ✅ Truth tracking (GSF)
• ✅ Truth tracking
• ✅ Particles inital fatras
• ✅ Particles final fatras
• ✅ Particles inital geant4
• ✅ Particles final geant4

[paulgessinger]

Hmm this runs for almost 2 hours now. I think we probably have to stick to full core count so it doesn't take forever.

I've gone back to full VMs per job so hopefully the clang-tidy should be less crashy.

[andiwand]

makes sense! I will revert the -j but otherwise I think the reporting and error handling still improved

[acts-project-service]

🔴 Athena integration test results

Build job with this PR failed!

Please investigate the build job for the pipeline!