ci: Improve clang tidy job (#2365)

Improves the output and error handling of the clang tidy job.

Before the CI job did not print the output of the clang tidy calls and the error code was ignored.

.gitlab-ci.yml

@@ -37,10 +37,8 @@ clang_tidy:
         -DACTS_BUILD_EVERYTHING=on
         -DACTS_RUN_CLANG_TIDY=on
 
-    - mkdir clang-tidy
-
     # Main clang-tidy run during cmake compilation
-    - CI/clang_tidy/run_clang_tidy.sh build | tee clang-tidy/clang-tidy.log
+    - CI/clang_tidy/run_clang_tidy.sh clang-tidy build
 
     # Install dependencies for processing scripts
     - pip install -r CI/clang_tidy/requirements.txt

CI/clang_tidy/run_clang_tidy.sh

@@ -1,8 +1,27 @@
 #!/bin/bash
+
+set -e
+
+output_dir=$1
+shift
 build_dir=$1
+shift
 
-export NINJA_STATUS="[ninja][%f/%t] "
+mkdir -p $output_dir
+output_dir=$(realpath $output_dir)
 
 pushd $build_dir
-ninja | grep -v '\[ninja\]'
+NINJA_STATUS="[ninja] [%f/%t] " ninja $@ | tee $output_dir/ninja.log
 popd
+
+# grep fails if it does not find anything
+set +e
+rm $output_dir/clang-tidy.log
+cat $output_dir/ninja.log | grep -v '\[ninja\]' > $output_dir/clang-tidy.log
+set -e
+
+if [ ! -f $output_dir/clang-tidy.log ]; then
+  exit 1
+fi
+
+exit 0