Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Exa.TrkX allow use of cluster information #2362

Merged
merged 245 commits into from
Aug 24, 2023

Conversation

benjaminhuth
Copy link
Member

This allows the use of cluster information in a (so far) quite unflexible way:

  • Each component can specify the number of features it uses.
  • The features are in a fixed order (r, phi, z, cell count, activation sum, cluster size x, cluster size y)
  • No reordering or slicing is possible currently, so a model cannot take (r, phi, activation sum, cell count) as input

Should go in after #2360

benjaminhuth and others added 30 commits May 25, 2022 20:44
@benjaminhuth benjaminhuth added the 🛑 blocked This item is blocked by another item label Aug 13, 2023
@benjaminhuth benjaminhuth added this to the next milestone Aug 13, 2023
@github-actions github-actions bot added Component - Examples Affects the Examples module Component - Plugins Affects one or more Plugins Track Finding labels Aug 13, 2023
@benjaminhuth benjaminhuth marked this pull request as draft August 13, 2023 16:12
@codecov
Copy link

codecov bot commented Aug 13, 2023

Codecov Report

Merging #2362 (d55f728) into main (27cd1e3) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #2362   +/-   ##
=======================================
  Coverage   49.54%   49.54%           
=======================================
  Files         453      453           
  Lines       25679    25679           
  Branches    11811    11811           
=======================================
  Hits        12722    12722           
  Misses       4583     4583           
  Partials     8374     8374           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@benjaminhuth benjaminhuth removed the 🛑 blocked This item is blocked by another item label Aug 22, 2023
@benjaminhuth benjaminhuth marked this pull request as ready for review August 23, 2023 09:54
andiwand
andiwand previously approved these changes Aug 23, 2023
@kodiakhq kodiakhq bot merged commit c4c3c80 into acts-project:main Aug 24, 2023
54 checks passed
@acts-project-service acts-project-service added the Fails Athena tests This PR causes a failure in the Athena tests label Aug 24, 2023
@paulgessinger paulgessinger modified the milestones: next, v29.0.0 Aug 25, 2023
@paulgessinger
Copy link
Member

Unrelated failure.

@paulgessinger paulgessinger removed the Fails Athena tests This PR causes a failure in the Athena tests label Aug 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component - Examples Affects the Examples module Component - Plugins Affects one or more Plugins Track Finding
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants