Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: ExaTrkX edge building KDTree on CPU + fixes + refactor + tests #2360

Merged
merged 15 commits into from
Aug 16, 2023
Merged

feat: ExaTrkX edge building KDTree on CPU + fixes + refactor + tests #2360

merged 15 commits into from
Aug 16, 2023

Conversation

benjaminhuth
Copy link
Member

@benjaminhuth benjaminhuth commented Aug 13, 2023 •
edited
Loading

  • Replaces brute force edge building with Acts::KDTree method
  • Abstracts std::vector to torch::Tensor conversions
  • Fixes bug in edge duplicate removal
  • Add more unit tests and enable in CI

@benjaminhuth benjaminhuth added this to the next milestone Aug 13, 2023
@github-actions github-actions bot added the Component - Plugins Affects one or more Plugins label Aug 13, 2023
@codecov
Copy link

codecov bot commented Aug 13, 2023 •
edited
Loading

Codecov Report

Merging #2360 (b23e9b3) into main (9cd59fd) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #2360   +/-   ##
=======================================
  Coverage   49.57%   49.57%           
=======================================
  Files         453      453           
  Lines       25513    25513           
  Branches    11707    11707           
=======================================
  Hits        12649    12649           
  Misses       4579     4579           
  Partials     8285     8285

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@github-actions
Copy link

github-actions bot commented Aug 13, 2023 •
edited
Loading

📊: Physics performance monitoring for b23e9b3

Full contents

physmon summary

@benjaminhuth benjaminhuth mentioned this pull request Aug 13, 2023
Merged
@benjaminhuth benjaminhuth mentioned this pull request Aug 13, 2023
Merged
@benjaminhuth benjaminhuth changed the title feat: ExaTrkX edge building KDTree on CPU + fixes + refactor feat: ExaTrkX edge building KDTree on CPU + fixes + refactor + tests Aug 16, 2023
@benjaminhuth benjaminhuth mentioned this pull request Aug 16, 2023
Merged
@github-actions github-actions bot added Component - Examples Affects the Examples module Changes Performance labels Aug 16, 2023
andiwand
andiwand previously approved these changes Aug 16, 2023
View reviewed changes
Copy link
Contributor

@andiwand andiwand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

took a quick look - looks good - nothing critical from my side

Plugins/ExaTrkX/include/Acts/Plugins/ExaTrkX/detail/buildEdges.hpp Show resolved Hide resolved
Plugins/ExaTrkX/src/buildEdges.cpp Outdated Show resolved Hide resolved
@benjaminhuth benjaminhuth marked this pull request as ready for review August 16, 2023 12:54
@kodiakhq kodiakhq bot merged commit 0486e42 into acts-project:main Aug 16, 2023
54 checks passed
@acts-project-service
Copy link
Collaborator

🔴 Athena integration test results

🔴 Some tests have failed!

Please investigate the pipeline!

status job
🟢 run_unit_tests
🟢 run_ci_tests: ../athena/AtlasTest/CITest/test/ActsWorkflow.sh
🟢 run_ci_tests: ../athena/AtlasTest/CITest/test/ActsValidateTracks.sh
🟢 run_ci_tests: ../athena/AtlasTest/CITest/test/ActsValidateActsCoreSpacePoints.sh
🟢 run_ci_tests: ../athena/AtlasTest/CITest/test/ActsValidateActsSpacePoints.sh
🟢 run_ci_tests: ../athena/AtlasTest/CITest/test/ActsValidateSeeds.sh
🟢 run_ci_tests: ../athena/AtlasTest/CITest/test/ActsValidateOrthogonalSeeds.sh
🟢 run_ci_tests: ../athena/AtlasTest/CITest/test/ActsValidateClusters.sh
🟢 run_ci_tests: ../athena/AtlasTest/CITest/test/ActsPersistifyEDM.sh
🟢 run_ci_tests: ../athena/AtlasTest/CITest/test/ActsKfRefitting.sh
🟢 run_ci_tests: python3 ../athena/Tracking/Acts/ActsGeometry/test/ActsExtrapolationAlgTest.py
🟢 run_ci_tests: python3 ../athena/Tracking/Acts/ActsGeometry/test/ActsITkTest.py
🟢 run_workflow_tests_run4_mc
🟢 run_workflow_tests_run2_mc
🔴 run_workflow_tests_run2_data
🟢 run_workflow_tests_run3_mc
🔴 run_workflow_tests_run3_data

@acts-project-service acts-project-service added the Fails Athena tests This PR causes a failure in the Athena tests label Aug 16, 2023
kodiakhq bot pushed a commit that referenced this pull request Aug 17, 2023
@benjaminhuth
fix: Exa.TrkX edge duplicate removal (#2373)
dd8188a 
should go in after #2360
@paulgessinger paulgessinger modified the milestones: next, v28.2.0 Aug 17, 2023
kodiakhq bot pushed a commit that referenced this pull request Aug 24, 2023
@benjaminhuth
feat: Exa.TrkX allow use of cluster information (#2362)
c4c3c80 
This allows the use of cluster information in a (so far) quite unflexible way:
* Each component can specify the number of features it uses.
* The features are in a fixed order (r, phi, z, cell count, activation sum, cluster size x, cluster size y)
* No reordering or slicing is possible currently, so a model cannot take (r, phi, activation sum, cell count) as input

Should go in after #2360
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andiwand andiwand andiwand approved these changes

Assignees
No one assigned
Labels
Changes Performance Component - Examples Affects the Examples module Component - Plugins Affects one or more Plugins Fails Athena tests This PR causes a failure in the Athena tests
Projects
None yet
Milestone
v28.2.0
Development

Successfully merging this pull request may close these issues.
4 participants
@benjaminhuth @acts-project-service @andiwand @paulgessinger