-
Notifications
You must be signed in to change notification settings - Fork 168
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Missing Include in CuboidVolumeBuilder #1786
fix: Missing Include in CuboidVolumeBuilder #1786
Conversation
📊 Physics performance monitoring for 77e1c0fFull report VertexingSeedingCKFAmbiguity resolutionTruth tracking (Kalman Filter)Truth tracking (GSF) |
Codecov Report
@@ Coverage Diff @@
## main #1786 +/- ##
=======================================
Coverage 49.77% 49.77%
=======================================
Files 406 406
Lines 22521 22521
Branches 10286 10286
=======================================
Hits 11210 11210
Misses 4132 4132
Partials 7179 7179
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
Hi @benjaminhuth it looks like physmon just failed... which makes no sense to me. I'm assuming this is a temporary glitch. how can I restart the CI? Or do you think it is not necessary for this change? |
I've restarted the failed jobs, let's hope it runs through this time! |
great @benjaminhuth the CI has indeed succeeded. Thanks! It looks though the automerge didn't happen? |
The PR was enqueued at 2nd position in the automerge list, but now #1771 has been merged and it should be 1st place now. You chan check the queue position by hovering the |
Indeed, it's now reached the front of the merge train 🚂 |
Self-Explanatory