Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Missing Include in CuboidVolumeBuilder #1786

Merged
merged 4 commits into from
Jan 17, 2023

Conversation

CarloVarni
Copy link
Collaborator

Self-Explanatory

@CarloVarni CarloVarni added this to the next milestone Jan 16, 2023
@CarloVarni CarloVarni added the Bug Something isn't working label Jan 16, 2023
@github-actions
Copy link

github-actions bot commented Jan 16, 2023

📊 Physics performance monitoring for 77e1c0f

Full report
Seeding: seeded, truth estimated, orthogonal
CKF: seeded, truth smeared, truth estimated, orthogonal
IVF: seeded, truth smeared, truth estimated, orthogonal
Ambiguity resolution: seeded, orthogonal
Truth tracking
Truth tracking (GSF)

Vertexing

Vertexing vs. mu
IVF seeded

IVF truth_smeared

IVF truth_estimated

IVF orthogonal

Seeding

Seeding seeded

Seeding truth_estimated

Seeding orthogonal

CKF

CKF seeded

CKF truth_smeared

CKF truth_estimated

CKF orthogonal

Ambiguity resolution

seeded

Truth tracking (Kalman Filter)

Truth tracking

Truth tracking (GSF)

Truth tracking

@codecov
Copy link

codecov bot commented Jan 16, 2023

Codecov Report

Merging #1786 (77e1c0f) into main (0bfaedb) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #1786   +/-   ##
=======================================
  Coverage   49.77%   49.77%           
=======================================
  Files         406      406           
  Lines       22521    22521           
  Branches    10286    10286           
=======================================
  Hits        11210    11210           
  Misses       4132     4132           
  Partials     7179     7179           
Impacted Files Coverage Δ
Core/include/Acts/Geometry/CuboidVolumeBuilder.hpp 33.33% <ø> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Member

@benjaminhuth benjaminhuth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@CarloVarni
Copy link
Collaborator Author

Hi @benjaminhuth it looks like physmon just failed... which makes no sense to me. I'm assuming this is a temporary glitch. how can I restart the CI? Or do you think it is not necessary for this change?

@benjaminhuth
Copy link
Member

I've restarted the failed jobs, let's hope it runs through this time!

@CarloVarni
Copy link
Collaborator Author

great @benjaminhuth the CI has indeed succeeded. Thanks! It looks though the automerge didn't happen?

@benjaminhuth
Copy link
Member

The PR was enqueued at 2nd position in the automerge list, but now #1771 has been merged and it should be 1st place now. You chan check the queue position by hovering the kodiakhq: status in the CI overview once the checks run through sucessfully :)

@paulgessinger
Copy link
Member

Indeed, it's now reached the front of the merge train 🚂

@kodiakhq kodiakhq bot merged commit 807c388 into acts-project:main Jan 17, 2023
@CarloVarni CarloVarni deleted the missing_include_Geometry branch January 17, 2023 10:56
@paulgessinger paulgessinger modified the milestones: next, v23.0.0 Jan 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants