Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix enum to test presence of inner tube cover surface. #1771

Merged

Conversation

goetzgaycken
Copy link
Contributor

Use correct enum to test whether a cylinder layer contains an inner tube cover surface.

Use correct enum to test whether a cylinder layer contains an inner
tube cover surface.
@AJPfleger AJPfleger added this to the next milestone Jan 9, 2023
@AJPfleger AJPfleger added Component - Core Affects the Core module Impact - Minor Nuissance bug and/or affects only a single module labels Jan 9, 2023
@codecov
Copy link

codecov bot commented Jan 16, 2023

Codecov Report

Merging #1771 (ad2aed3) into main (f266387) will not change coverage.
The diff coverage is 0.00%.

@@           Coverage Diff           @@
##             main    #1771   +/-   ##
=======================================
  Coverage   49.77%   49.77%           
=======================================
  Files         406      406           
  Lines       22521    22521           
  Branches    10286    10286           
=======================================
  Hits        11210    11210           
  Misses       4132     4132           
  Partials     7179     7179           
Impacted Files Coverage Δ
Core/src/Geometry/CylinderLayer.cpp 43.33% <0.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@github-actions
Copy link

github-actions bot commented Jan 16, 2023

📊 Physics performance monitoring for ad2aed3

Full report
Seeding: seeded, truth estimated, orthogonal
CKF: seeded, truth smeared, truth estimated, orthogonal
IVF: seeded, truth smeared, truth estimated, orthogonal
Ambiguity resolution: seeded, orthogonal
Truth tracking
Truth tracking (GSF)

Vertexing

Vertexing vs. mu
IVF seeded

IVF truth_smeared

IVF truth_estimated

IVF orthogonal

Seeding

Seeding seeded

Seeding truth_estimated

Seeding orthogonal

CKF

CKF seeded

CKF truth_smeared

CKF truth_estimated

CKF orthogonal

Ambiguity resolution

seeded

Truth tracking (Kalman Filter)

Truth tracking

Truth tracking (GSF)

Truth tracking

@kodiakhq kodiakhq bot merged commit 0bfaedb into acts-project:main Jan 17, 2023
@paulgessinger paulgessinger modified the milestones: next, v23.0.0 Jan 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component - Core Affects the Core module Impact - Minor Nuissance bug and/or affects only a single module
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants