Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor!: Set calibratedSize only through allocateCalibrated #1749

Merged
merged 2 commits into from
Dec 15, 2022

Conversation

paulgessinger
Copy link
Member

Closes #1743

@paulgessinger paulgessinger added this to the next milestone Dec 14, 2022
@codecov
Copy link

codecov bot commented Dec 14, 2022

Codecov Report

Merging #1749 (df24f40) into main (0590e9d) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #1749      +/-   ##
==========================================
- Coverage   49.29%   49.28%   -0.01%     
==========================================
  Files         395      395              
  Lines       21809    21806       -3     
  Branches     9925     9925              
==========================================
- Hits        10751    10748       -3     
  Misses       4179     4179              
  Partials     6879     6879              
Impacted Files Coverage Δ
Core/include/Acts/EventData/MultiTrajectory.hpp 71.03% <ø> (-0.32%) ⬇️
...e/include/Acts/EventData/VectorMultiTrajectory.hpp 58.42% <100.00%> (+0.21%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@github-actions
Copy link

github-actions bot commented Dec 14, 2022

📊 Physics performance monitoring for df24f40

Full report
Seeding: seeded, truth estimated, orthogonal
CKF: seeded, truth smeared, truth estimated, orthogonal
IVF: seeded, truth smeared, truth estimated, orthogonal
Ambiguity resolution: seeded, orthogonal
Truth tracking
Truth tracking (GSF)

Vertexing

Vertexing vs. mu
IVF seeded

IVF truth_smeared

IVF truth_estimated

IVF orthogonal

Seeding

Seeding seeded

Seeding truth_estimated

Seeding orthogonal

CKF

CKF seeded

CKF truth_smeared

CKF truth_estimated

CKF orthogonal

Ambiguity resolution

seeded

Truth tracking (Kalman Filter)

Truth tracking

Truth tracking (GSF)

Truth tracking

Copy link
Contributor

@tboldagh tboldagh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent. Thanks Paul!

@kodiakhq kodiakhq bot merged commit d590d8b into acts-project:main Dec 15, 2022
@paulgessinger paulgessinger modified the milestones: next, v22.0.0 Dec 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update of calibrate measurement size should become internal to the MTJ backend
3 participants