-
Notifications
You must be signed in to change notification settings - Fork 168
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update of calibrate measurement size should become internal to the MTJ backend #1743
Comments
So you would make |
Yes. And the update of the size handled by allocateCallibrated which would be backend dependent anyways. |
That was quick. Thanks. There may be another small issue here. The calibratedSize is now using "component" to get to the actual size. In ATLAS xAOD implementation this would require that we somehow get the pointer to the vector size property. Not sure if that is doable. Not sure how to best solve it. Duplicating this information in the vector & in mesdim variable seems like asking for trouble. |
Oh that's a good point I didn't consider yet. I suppose we could instead special case the |
We can indeed specialise it! Nonissue then. |
No I believe you're right than in the current implementation it tries to cast it to a pointer, which will break if the backend passes the size by value. So I think some form of fix is still needed. |
This is to facilitate backends where the calibrated size is calculated on demand, and can't easily be returned by reference. See also #1743
In the MTJ implementation we have such line:
acts/Core/include/Acts/EventData/MultiTrajectory.hpp
Line 931 in 5cab50d
This sets the size of the calibrated measurement. However with different backend (xAOD in ATLAS) we do not need this extra size as the data is kept in vector<vector> and the size is known. We can add a fictional method to update the size but
it seems that we can eliminate this method:
acts/Core/include/Acts/EventData/MultiTrajectory.hpp
Line 888 in 5cab50d
and let the allocateCallibrated to handle this update.
Tagging @paulgessinger
and for info @CarloVarni Marcin Wolter
The text was updated successfully, but these errors were encountered: