Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Seed filter should make no use of external sp methods #1744

Merged
merged 8 commits into from
Dec 19, 2022
Merged

fix: Seed filter should make no use of external sp methods #1744

Changes from 3 commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
8922478
Use methods of internal space point instead of accessing the stored e…
Dec 14, 2022
046d41c
Merge branch 'main' into SeedFilterNoExternalMethods
CarloVarni Dec 14, 2022
7438c8e
Merge branch 'main' into SeedFilterNoExternalMethods
CarloVarni Dec 14, 2022
8b14ef6
Merge branch 'main' into SeedFilterNoExternalMethods
CarloVarni Dec 15, 2022
d06ceeb
Merge branch 'main' into SeedFilterNoExternalMethods
CarloVarni Dec 15, 2022
9c253ad
Merge branch 'main' into SeedFilterNoExternalMethods
CarloVarni Dec 15, 2022
66e44cf
Merge branch 'main' into SeedFilterNoExternalMethods
CarloVarni Dec 15, 2022
52779f5
Merge branch 'main' into SeedFilterNoExternalMethods
CarloVarni Dec 19, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions Core/include/Acts/Seeding/SeedFilter.ipp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -268,10 +268,10 @@ void SeedFilter<external_spacepoint_t>::filterSeeds_1SpFixed(
float seed1_sum = 0;
float seed2_sum = 0;
for (int i = 0; i < 3; i++) {
seed1_sum += pow(i1.second->sp[i]->sp().y(), 2) +
pow(i1.second->sp[i]->sp().z(), 2);
seed2_sum += pow(i2.second->sp[i]->sp().y(), 2) +
pow(i2.second->sp[i]->sp().z(), 2);
seed1_sum += pow(i1.second->sp[i]->y(), 2) +
CarloVarni marked this conversation as resolved.
Show resolved Hide resolved
pow(i1.second->sp[i]->z(), 2);
seed2_sum += pow(i2.second->sp[i]->y(), 2) +
pow(i2.second->sp[i]->z(), 2);
}
return seed1_sum > seed2_sum;
}
Expand Down