fix: Seed filter should make no use of external sp methods #1744
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
tagging @paulgessinger These changes were started from |
…xternal sp methods
CarloVarni
force-pushed
the
SeedFilterNoExternalMethods
branch
from
be9ace2
to
8922478
Compare
Codecov Report
@@ Coverage Diff @@
## main #1744 +/- ##
=======================================
Coverage 49.14% 49.14%
=======================================
Files 395 395
Lines 21800 21800
Branches 9953 9953
=======================================
Hits 10713 10713
Misses 4187 4187
Partials 6900 6900
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
📊 Physics performance monitoring for 52779f5Full report VertexingVertexing vs. muIVF seededIVF truth_smearedIVF truth_estimatedIVF orthogonalSeedingSeeding seededSeeding truth_estimatedSeeding orthogonalCKFCKF seededCKF truth_smearedCKF truth_estimatedCKF orthogonalAmbiguity resolutionseededTruth tracking (Kalman Filter)Truth trackingTruth tracking (GSF)Truth tracking |
tboldagh
approved these changes
Dec 15, 2022
CarloVarni
added a commit
to CarloVarni/acts
that referenced
this pull request
Dec 22, 2022
…ect#1744) As the name says... This would prevent us from using the seed on an input collection that does not implement the `y()` and `z()` method. We do not know what the costumer EDM looks like and these same values can already be retrieved without using the external sp methods
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As the name says...
This would prevent us from using the seed on an input collection that does not implement the
y()andz()method. We do not know what the costumer EDM looks like and these same values can already be retrieved without using the external sp methods