Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: GX2F: write correct chi2 to root #1725

Merged
merged 24 commits into from
Dec 14, 2022
Merged
Changes from 22 commits
Commits
Show all changes
24 commits
Select commit Hold shift + click to select a range
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions Core/include/Acts/TrackFitting/Chi2Fitter.hpp
Original file line number Diff line number Diff line change
Expand Up @@ -428,6 +428,10 @@ class Chi2Fitter {
result.collectorDerive1Chi2Sum += derive1Chi2;
result.collectorDerive2Chi2Sum += derive2Chi2;

double localChi2 =
(residuals.transpose() * covInv * residuals).eval()(0);
trackStateProxy.chi2() = localChi2;

for (int i = 0; i < localMeasurements.rows(); ++i) {
result.collectorMeasurements.push_back(localMeasurements(i));
result.collectorResiduals.push_back(residuals(i));
Expand Down