Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: GX2F: write correct chi2 to root #1725

Merged
merged 24 commits into from
Dec 14, 2022
Merged

Conversation

AJPfleger
Copy link
Contributor

Prior, no chi2-values were written with the states/summary-writers.

@AJPfleger AJPfleger added Component - Core Affects the Core module Impact - Minor Nuissance bug and/or affects only a single module labels Dec 8, 2022
@AJPfleger AJPfleger added this to the next milestone Dec 8, 2022
@AJPfleger AJPfleger changed the title add: GX2F: write correct chi2 to root fix: GX2F: write correct chi2 to root Dec 8, 2022
@github-actions
Copy link

github-actions bot commented Dec 8, 2022

📊 Physics performance monitoring for 3f33b2a

Full report
Seeding: seeded, truth estimated, orthogonal
CKF: seeded, truth smeared, truth estimated, orthogonal
IVF: seeded, truth smeared, truth estimated, orthogonal
Ambiguity resolution: seeded, orthogonal
Truth tracking
Truth tracking (GSF)

Vertexing

Vertexing vs. mu
IVF seeded

IVF truth_smeared

IVF truth_estimated

IVF orthogonal

Seeding

Seeding seeded

Seeding truth_estimated

Seeding orthogonal

CKF

CKF seeded

CKF truth_smeared

CKF truth_estimated

CKF orthogonal

Ambiguity resolution

seeded

Truth tracking (Kalman Filter)

Truth tracking

Truth tracking (GSF)

Truth tracking

@codecov
Copy link

codecov bot commented Dec 8, 2022

Codecov Report

Merging #1725 (3f33b2a) into main (0aa3259) will decrease coverage by 0.00%.
The diff coverage is 33.33%.

@@            Coverage Diff             @@
##             main    #1725      +/-   ##
==========================================
- Coverage   49.20%   49.20%   -0.01%     
==========================================
  Files         398      398              
  Lines       21850    21853       +3     
  Branches     9914     9916       +2     
==========================================
+ Hits        10752    10753       +1     
  Misses       4222     4222              
- Partials     6876     6878       +2     
Impacted Files Coverage Δ
Core/include/Acts/TrackFitting/Chi2Fitter.hpp 35.21% <33.33%> (-0.03%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@kodiakhq kodiakhq bot merged commit 3198781 into acts-project:main Dec 14, 2022
@paulgessinger paulgessinger modified the milestones: next, v22.0.0 Dec 21, 2022
CarloVarni pushed a commit to CarloVarni/acts that referenced this pull request Dec 22, 2022
Prior, no chi2-values were written with the states/summary-writers.
@AJPfleger AJPfleger deleted the chi2 branch December 1, 2023 12:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component - Core Affects the Core module Impact - Minor Nuissance bug and/or affects only a single module
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants