Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: seeding performance monitoring #1665

Merged
merged 30 commits into from
Nov 16, 2022
Merged
Show file tree
Hide file tree
Changes from 5 commits
Commits
Show all changes
30 commits
Select commit Hold shift + click to select a range
1f23823
seeding efficiency plots
LuisFelipeCoelho Nov 9, 2022
4bded8b
Merge branch 'main' into seeding-monitoring
LuisFelipeCoelho Nov 9, 2022
03c9cfc
format
LuisFelipeCoelho Nov 9, 2022
5503a5c
Merge branch 'seeding-monitoring' of https://github.com/LuisFelipeCoe…
LuisFelipeCoelho Nov 9, 2022
9f26dbc
fix mistake
LuisFelipeCoelho Nov 9, 2022
ad408d5
fix mistakes
LuisFelipeCoelho Nov 9, 2022
4b92a2f
fix stem
LuisFelipeCoelho Nov 11, 2022
265490a
Merge branch 'main' into seeding-monitoring
LuisFelipeCoelho Nov 11, 2022
5740fa2
add root files
LuisFelipeCoelho Nov 11, 2022
9fc0d88
Merge branch 'seeding-monitoring' of https://github.com/LuisFelipeCoe…
LuisFelipeCoelho Nov 11, 2022
bba9f72
add orthogonal seeding
LuisFelipeCoelho Nov 11, 2022
594677b
orthogonal seeding plots in git comment
LuisFelipeCoelho Nov 11, 2022
0ab85e6
add orthogonal root file
LuisFelipeCoelho Nov 11, 2022
402633c
more plots
LuisFelipeCoelho Nov 11, 2022
0a435c9
fix root file name
LuisFelipeCoelho Nov 12, 2022
2a8420d
fix git comment
LuisFelipeCoelho Nov 12, 2022
7cacdce
fix mistake
LuisFelipeCoelho Nov 12, 2022
0b2174a
Merge branch 'acts-project:main' into seeding-monitoring
LuisFelipeCoelho Nov 14, 2022
8132350
Merge branch 'main' into seeding-monitoring
LuisFelipeCoelho Nov 14, 2022
3d1f19c
fix issues
LuisFelipeCoelho Nov 14, 2022
da1d6a6
Merge branch 'seeding-monitoring' of https://github.com/LuisFelipeCoe…
LuisFelipeCoelho Nov 14, 2022
2184568
fix string
LuisFelipeCoelho Nov 14, 2022
02cfae6
fix residuals_and_pulls_orthogonal file
LuisFelipeCoelho Nov 14, 2022
8e61c5d
remove pulls orthogonal + fix hist
LuisFelipeCoelho Nov 15, 2022
a693171
acts_analysis_residuals_and_pulls.root file
LuisFelipeCoelho Nov 15, 2022
46fde6b
fix file name
LuisFelipeCoelho Nov 15, 2022
42fc998
fix vertexing file
LuisFelipeCoelho Nov 15, 2022
2f297d5
Merge branch 'main' into seeding-monitoring
LuisFelipeCoelho Nov 15, 2022
0b0262a
update plots
LuisFelipeCoelho Nov 16, 2022
b8eaa24
Merge branch 'main' into seeding-monitoring
LuisFelipeCoelho Nov 16, 2022
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 22 additions & 0 deletions CI/physmon/comment_template.md
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,28 @@ IVF: {{ make_url("seeded", "ivf_seeded.html") }}, {{ make_url("truth smeared", "

{% endfor %}

### Seeding {{ "" if all_exist(
"seeding_seeded_plots",
"seeding_truth_smeared_plots",
"seeding_truth_estimated_plots",
) else ":x: "}}

{% for mode in ["seeded", "truth_smeared", "truth_estimated"] %}

{% call detail_block("Seeding "+mode, "seeding_"+mode+"_plots") %}

{% for url in [
"trackeff_vs_eta.pdf",
"trackeff_vs_pT.pdf",
"duplicationRate_vs_eta.pdf",
"duplicationRate_vs_pT.pdf",
] -%}
{{- make_image("seeding_"+mode+"_plots/"+url, "50%") -}}
{%- endfor %}

{% endcall %}

{% endfor %}

### CKF {{ "" if all_exist(
"ckf_seeded_plots",
Expand Down
14 changes: 11 additions & 3 deletions CI/physmon/phys_perf_mon.sh
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,15 @@ function full_chain() {
fi
echo $config

run \
run \
$outdir/performance_seeding_hists_${suffix}.root \
$refdir/performance_seeding_hists_${suffix}.root \
--title "Seeding ${suffix}" \
-c $config \
-o $outdir/seeding_${suffix}.html \
-p $outdir/seeding_${suffix}_plots

run \
$outdir/performance_ckf_${suffix}.root \
$refdir/performance_ckf_${suffix}.root \
--title "CKF ${suffix}" \
Expand Down Expand Up @@ -91,8 +99,8 @@ run \
$outdir/acts_analysis_residuals_and_pulls.root \
$refdir/acts_analysis_residuals_and_pulls.root \
--title "analysis_residuals_and_pulls" \
# -o $outdir/analysis_residuals_and_pulls.html \
# -p $outdir/analysis_residuals_and_pulls
-o $outdir/analysis_residuals_and_pulls.html \
-p $outdir/analysis_residuals_and_pulls
LuisFelipeCoelho marked this conversation as resolved.
Show resolved Hide resolved

Examples/Scripts/vertex_mu_scan.py \
$outdir/performance_vertexing_*mu*.root \
Expand Down
10 changes: 8 additions & 2 deletions CI/physmon/physmon.py
Original file line number Diff line number Diff line change
Expand Up @@ -210,8 +210,14 @@
s.run()
del s

for stem in ["performance_ckf", "performance_vertexing"] + (
["performance_ambi"] if label == "seeded" else []
for stem in [
"performance_seeding_hists",
"performance_ckf",
"performance_vertexing",
] + (
["performance_seeding_hists", "performance_ambi"]
if label == "seeded"
else []
):
perf_file = tp / f"{stem}.root"
assert perf_file.exists(), "Performance file not found"
Expand Down