Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: seeding performance monitoring #1665

Merged
merged 30 commits into from
Nov 16, 2022
Merged

feat: seeding performance monitoring #1665

merged 30 commits into from
Nov 16, 2022

Conversation

LuisFelipeCoelho
Copy link
Member

No description provided.

@LuisFelipeCoelho LuisFelipeCoelho added Improvement Changes to an existing feature 🚧 WIP Work-in-progress labels Nov 9, 2022
@LuisFelipeCoelho LuisFelipeCoelho added this to the next milestone Nov 9, 2022
@LuisFelipeCoelho LuisFelipeCoelho removed the Improvement Changes to an existing feature label Nov 9, 2022
@paulgessinger
Copy link
Member

This looks pretty good already, thank!

andiwand
andiwand reviewed Nov 9, 2022
View reviewed changes
Copy link
Contributor

@andiwand andiwand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great to have this! looking forward to the first plots

@codecov
Copy link

codecov bot commented Nov 9, 2022 •
edited
Loading

Codecov Report

Merging #1665 (b8eaa24) into main (85a6775) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #1665   +/-   ##
=======================================
  Coverage   48.58%   48.58%           
=======================================
  Files         382      382           
  Lines       21059    21059           
  Branches     9644     9644           
=======================================
  Hits        10232    10232           
  Misses       4147     4147           
  Partials     6680     6680

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@github-actions
Copy link

github-actions bot commented Nov 9, 2022 •
edited
Loading

📊 Physics performance monitoring for 0b0262a

Full report
CKF: seeded, truth smeared, truth estimated
IVF: seeded, truth smeared, truth estimated
Ambiguity resolution
Truth tracking (Kalman Filter)
Truth tracking (GSF)

Vertexing

Vertexing vs. mu
IVF seeded

IVF truth_smeared

IVF truth_estimated

CKF

CKF seeded

CKF truth_smeared

CKF truth_estimated

Ambiguity resolution

seeded

Truth tracking (Kalman Filter)

Truth tracking

Truth tracking (GSF)

Truth tracking

@LuisFelipeCoelho
Copy link
Member Author

@paulgessinger should I also add the monitoring for the orthogonal seeding?

@LuisFelipeCoelho LuisFelipeCoelho marked this pull request as ready for review November 11, 2022 13:52
@paulgessinger
Copy link
Member

If you can, that would of course be brilliant.

@LuisFelipeCoelho
Copy link
Member Author

I don't know why the github-actions doesn't show the new plots

@LuisFelipeCoelho
Copy link
Member Author

Ok I will remove the residuals and pulls for the orthogonal seeding.

tracking_eff_eta and tracking_eff_pT are the plots from performance_seeding_hists.root. I think this is the seeding efficiency from SeedingPerformanceWriter, right?

@paulgessinger
Copy link
Member

Might make sense to change the name in the performance writer maybe?

@LuisFelipeCoelho
Copy link
Member Author

yes, I agree that the name should be changed, but I think I will make another PR for it, because I also want to include more variables in the seeding performance

@paulgessinger
Copy link
Member

Orthogonal seeding reference seems to be off. Should this already match @LuisFelipeCoelho ?

@paulgessinger paulgessinger mentioned this pull request Nov 16, 2022
Merged
@LuisFelipeCoelho
Copy link
Member Author

@paulgessinger I will update the plots

@LuisFelipeCoelho
Copy link
Member Author

I hope now the physmon won't fail

@LuisFelipeCoelho
Copy link
Member Author

I think this is finally ready. Thank you @paulgessinger and @andiwand for the help

@paulgessinger
Copy link
Member

docs build failure is unrelated I think.

@paulgessinger paulgessinger merged commit 7da4880 into acts-project:main Nov 16, 2022
@LuisFelipeCoelho LuisFelipeCoelho deleted the seeding-monitoring branch November 16, 2022 15:25
@LuisFelipeCoelho LuisFelipeCoelho mentioned this pull request Nov 22, 2022
Merged
kodiakhq bot pushed a commit that referenced this pull request Nov 23, 2022
@LuisFelipeCoelho
fix: comment_template bugs for seeding monitoring (#1683)
89c62ea 
This PR fixes some bugs from #1665 seeding performance monitoring
pbutti pushed a commit to pbutti/acts that referenced this pull request Dec 13, 2022
@LuisFelipeCoelho @pbutti
fix: comment_template bugs for seeding monitoring (acts-project#1683)
4cc1681 
This PR fixes some bugs from acts-project#1665 seeding performance monitoring
@paulgessinger paulgessinger modified the milestones: next, v22.0.0 Dec 21, 2022
CarloVarni pushed a commit to CarloVarni/acts that referenced this pull request Dec 22, 2022
@LuisFelipeCoelho
feat: seeding performance monitoring (acts-project#1665)
f183cdb
CarloVarni pushed a commit to CarloVarni/acts that referenced this pull request Dec 22, 2022
@LuisFelipeCoelho
fix: comment_template bugs for seeding monitoring (acts-project#1683)
6b45cf8 
This PR fixes some bugs from acts-project#1665 seeding performance monitoring
@LuisFelipeCoelho LuisFelipeCoelho restored the seeding-monitoring branch January 16, 2023 11:19
@LuisFelipeCoelho LuisFelipeCoelho deleted the seeding-monitoring branch January 16, 2023 11:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andiwand andiwand andiwand left review comments

@paulgessinger paulgessinger paulgessinger approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v22.0.0
Development

Successfully merging this pull request may close these issues.
3 participants
@LuisFelipeCoelho @paulgessinger @andiwand