Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: adding portal, detector volume & detector #1645

Merged
merged 45 commits into from
Nov 22, 2022
Merged

feat: adding portal, detector volume & detector #1645

merged 45 commits into from
Nov 22, 2022

Commits on Nov 18, 2022

  1. adding portal, detector volume & detector

    @asalzburger
    asalzburger committed Nov 18, 2022
    Configuration menu
    Copy the full SHA
    175c495 View commit details
    Browse the repository at this point in the history

  2. fix param list for documentation

    @asalzburger
    asalzburger committed Nov 18, 2022
    Configuration menu
    Copy the full SHA
    0388b33 View commit details
    Browse the repository at this point in the history

  3. adding local navigation description

    @asalzburger
    asalzburger committed Nov 18, 2022
    Configuration menu
    Copy the full SHA
    8e62f00 View commit details
    Browse the repository at this point in the history

  4. fixing compilation errors in CI

    @asalzburger
    asalzburger committed Nov 18, 2022
    Configuration menu
    Copy the full SHA
    c5c6a57 View commit details
    Browse the repository at this point in the history

  5. adding Portal UnitTest

    @asalzburger
    asalzburger committed Nov 18, 2022
    Configuration menu
    Copy the full SHA
    b261604 View commit details
    Browse the repository at this point in the history

  6. adding navigation state updators and tests for them

    @asalzburger
    asalzburger committed Nov 18, 2022
    Configuration menu
    Copy the full SHA
    cb913b3 View commit details
    Browse the repository at this point in the history

  7. documentation update

    @asalzburger
    asalzburger committed Nov 18, 2022
    Configuration menu
    Copy the full SHA
    0971c65 View commit details
    Browse the repository at this point in the history

  8. remove containment check for the moment

    @asalzburger
    asalzburger committed Nov 18, 2022
    Configuration menu
    Copy the full SHA
    cb81306 View commit details
    Browse the repository at this point in the history

  9. Tests/UnitTests/Core/Geometry/PortalTests.cpp

    @asalzburger
    asalzburger committed Nov 18, 2022
    Configuration menu
    Copy the full SHA
    e009561 View commit details
    Browse the repository at this point in the history

  10. add navigation state updates test

    @asalzburger
    asalzburger committed Nov 18, 2022
    Configuration menu
    Copy the full SHA
    246045f View commit details
    Browse the repository at this point in the history

  11. add detector volumes updates and their tests

    @asalzburger
    asalzburger committed Nov 18, 2022
    Configuration menu
    Copy the full SHA
    2dfe835 View commit details
    Browse the repository at this point in the history

  12. adding portal generator and tests

    @asalzburger
    asalzburger committed Nov 18, 2022
    Configuration menu
    Copy the full SHA
    280ff4d View commit details
    Browse the repository at this point in the history

  13. adding detector volume finder & tests

    @asalzburger
    asalzburger committed Nov 18, 2022
    Configuration menu
    Copy the full SHA
    48536a0 View commit details
    Browse the repository at this point in the history

  14. feat-portal-volume-detector

    @asalzburger
    asalzburger committed Nov 18, 2022
    Configuration menu
    Copy the full SHA
    cfd1e7a View commit details
    Browse the repository at this point in the history

  15. adding Detector tests

    @asalzburger
    asalzburger committed Nov 18, 2022
    Configuration menu
    Copy the full SHA
    8a46d3c View commit details
    Browse the repository at this point in the history

  16. some cleanup

    @asalzburger
    asalzburger committed Nov 18, 2022
    Configuration menu
    Copy the full SHA
    523ae24 View commit details
    Browse the repository at this point in the history

  17. make CUDA CI happy

    @asalzburger
    asalzburger committed Nov 18, 2022
    Configuration menu
    Copy the full SHA
    3004109 View commit details
    Browse the repository at this point in the history

  18. make CI happy, part 2

    @asalzburger
    asalzburger committed Nov 18, 2022
    Configuration menu
    Copy the full SHA
    c9d687f View commit details
    Browse the repository at this point in the history

  19. make CI happy, part 3

    @asalzburger
    asalzburger committed Nov 18, 2022
    Configuration menu
    Copy the full SHA
    a87e598 View commit details
    Browse the repository at this point in the history

  20. addressing PR comments

    @asalzburger
    asalzburger committed Nov 18, 2022
    Configuration menu
    Copy the full SHA
    4b37f46 View commit details
    Browse the repository at this point in the history

  21. clang-format

    @asalzburger
    asalzburger committed Nov 18, 2022
    Configuration menu
    Copy the full SHA
    508045d View commit details
    Browse the repository at this point in the history

  22. trying [[maybe_unused]]

    @asalzburger
    asalzburger committed Nov 18, 2022
    Configuration menu
    Copy the full SHA
    5179223 View commit details
    Browse the repository at this point in the history

  23. trying adding assert message

    @asalzburger
    asalzburger committed Nov 18, 2022
    Configuration menu
    Copy the full SHA
    b63cb66 View commit details
    Browse the repository at this point in the history

  24. update docs

    @asalzburger
    asalzburger committed Nov 18, 2022
    Configuration menu
    Copy the full SHA
    3af4721 View commit details
    Browse the repository at this point in the history

  25. update comment a big

    @asalzburger
    asalzburger committed Nov 18, 2022
    Configuration menu
    Copy the full SHA
    444cd0e View commit details
    Browse the repository at this point in the history

  26. adding new unit tests

    @asalzburger
    asalzburger committed Nov 18, 2022
    Configuration menu
    Copy the full SHA
    a9801a9 View commit details
    Browse the repository at this point in the history

  27. addressing more PR comments

    @asalzburger
    asalzburger committed Nov 18, 2022
    Configuration menu
    Copy the full SHA
    7c1e94e View commit details
    Browse the repository at this point in the history

  28. make CI/Docs happy

    @asalzburger
    asalzburger committed Nov 18, 2022
    Configuration menu
    Copy the full SHA
    5eaa049 View commit details
    Browse the repository at this point in the history

  29. addressing more PR comments, add unit tests for ManagedDelegate and C… 

    …ommon functions
    @asalzburger
    asalzburger committed Nov 18, 2022
    Configuration menu
    Copy the full SHA
    bf4d2de View commit details
    Browse the repository at this point in the history

  30. removing BOOST_TEST

    @asalzburger
    asalzburger committed Nov 18, 2022
    Configuration menu
    Copy the full SHA
    ddeb4ec View commit details
    Browse the repository at this point in the history

  31. Update Core/include/Acts/Geometry/detail/PortalHelper.hpp 

    Co-authored-by: Paul Gessinger <[email protected]>
    @asalzburger @paulgessinger
    asalzburger and paulgessinger committed Nov 18, 2022
    Configuration menu
    Copy the full SHA
    3784d7a View commit details
    Browse the repository at this point in the history

  32. Update Core/include/Acts/Geometry/detail/PortalGenerators.hpp 

    Co-authored-by: Paul Gessinger <[email protected]>
    @asalzburger @paulgessinger
    asalzburger and paulgessinger committed Nov 18, 2022
    Configuration menu
    Copy the full SHA
    ca47ed9 View commit details
    Browse the repository at this point in the history

  33. addressing more PR comments

    @asalzburger
    asalzburger committed Nov 18, 2022
    Configuration menu
    Copy the full SHA
    d68c91b View commit details
    Browse the repository at this point in the history

  34. adding std::move() to delegates

    @asalzburger
    asalzburger committed Nov 18, 2022
    Configuration menu
    Copy the full SHA
    d735236 View commit details
    Browse the repository at this point in the history

  35. adding std::move() to delegates

    @asalzburger
    asalzburger committed Nov 18, 2022
    Configuration menu
    Copy the full SHA
    bec1007 View commit details
    Browse the repository at this point in the history

  36. first rebase

    @asalzburger
    asalzburger committed Nov 18, 2022
    Configuration menu
    Copy the full SHA
    7ca0dc2 View commit details
    Browse the repository at this point in the history

  37. update to new OwningDelegate infrastructure

    @asalzburger
    asalzburger committed Nov 18, 2022
    Configuration menu
    Copy the full SHA
    8fa1485 View commit details
    Browse the repository at this point in the history

  38. fixing make_unique instead of unique_ptr

    @asalzburger
    asalzburger committed Nov 18, 2022
    Configuration menu
    Copy the full SHA
    e1aac7a View commit details
    Browse the repository at this point in the history

  39. first round of clang-tidy comments

    @asalzburger
    asalzburger committed Nov 18, 2022
    Configuration menu
    Copy the full SHA
    c24bdc1 View commit details
    Browse the repository at this point in the history

Commits on Nov 20, 2022

  1. clang-tidy fix

    @asalzburger
    asalzburger committed Nov 20, 2022
    Configuration menu
    Copy the full SHA
    dbe0fb8 View commit details
    Browse the repository at this point in the history

  2. fix unit test

    @asalzburger
    asalzburger committed Nov 20, 2022
    Configuration menu
    Copy the full SHA
    6201a13 View commit details
    Browse the repository at this point in the history

Commits on Nov 21, 2022

  1. next round of clang-tidiness

    @asalzburger
    asalzburger committed Nov 21, 2022
    Configuration menu
    Copy the full SHA
    91b5627 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' into feat-portal-volume-detector

    @asalzburger
    asalzburger authored Nov 21, 2022
    Configuration menu
    Copy the full SHA
    7fe9244 View commit details
    Browse the repository at this point in the history

  3. clang-overtidy

    @asalzburger
    asalzburger committed Nov 21, 2022
    Configuration menu
    Copy the full SHA
    8cf546b View commit details
    Browse the repository at this point in the history

  4. Merge branch 'main' into feat-portal-volume-detector

    @asalzburger
    asalzburger authored Nov 21, 2022
    Configuration menu
    Copy the full SHA
    ed0b274 View commit details
    Browse the repository at this point in the history