-
Notifications
You must be signed in to change notification settings - Fork 168
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: adding portal, detector volume & detector #1645
feat: adding portal, detector volume & detector #1645
Conversation
Codecov Report
@@ Coverage Diff @@
## main #1645 +/- ##
==========================================
+ Coverage 48.58% 48.98% +0.39%
==========================================
Files 382 397 +15
Lines 21061 21497 +436
Branches 9645 9801 +156
==========================================
+ Hits 10233 10530 +297
- Misses 4147 4171 +24
- Partials 6681 6796 +115
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
📊 Physics performance monitoring for ed0b274
Full report VertexingSeeding ❌❌ Seeding truth_smeared CKFAmbiguity resolutionTruth tracking (Kalman Filter)Truth tracking (GSF) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
took a first look but left out the test code for now
Core/include/Acts/Geometry/detail/SurfaceCandidatesUpdators.hpp
Outdated
Show resolved
Hide resolved
8f17826
to
3ee3814
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is how far I got so far. Commenting this first batch now, but might have more later.
1ef4a8c
to
beee566
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can't really provide any more feedback right now. for me it would be good to bring it in and then test it with some real examples
Core/include/Acts/Geometry/detail/SurfaceCandidatesUpdators.hpp
Outdated
Show resolved
Hide resolved
Core/include/Acts/Geometry/detail/SurfaceCandidatesUpdators.hpp
Outdated
Show resolved
Hide resolved
There's one discussion point open, i.e. whether we should give the access to the const object to the iterators.
|
e55708c
to
545edea
Compare
Co-authored-by: Paul Gessinger <[email protected]>
Co-authored-by: Paul Gessinger <[email protected]>
63e8344
to
8fa1485
Compare
I've updated this to the new |
The debug unit test seems to fail, checking it now. |
Hey @andiwand - I think now all the clang-tidy fixes are also through, and the PR is reworked after @paulgessinger 's introduction of the There will be some ironing out of a few things certainly along the way, but since this is under |
@andiwand - if you're happy, please re-approve |
Since @andiwand approved and gave a thumbs up, I will merge that in. |
This PR adds the new Portal, DetectorVolume and Detector geometry which is meant to eventually replace the Layer, TrackingVolume, TrackingGeometry infrastructure. The new classes are currently put under the Experimental namespace. Only the new classes, the necessary definitions and unit tests are added with this PR, which will be followed up by the visualisation, the detector building and the navigation code. A description of the concepts and classes is added to the docs/experimental_geometry.md to this PR.
This PR adds the new
Portal
,DetectorVolume
andDetector
geometry which is meant to eventually replace theLayer
,TrackingVolume
,TrackingGeometry
infrastructure.The new classes are currently put under the
Experimental
namespace.Only the new classes, the necessary definitions and unit tests are added with this PR, which will be followed up by the visualisation, the detector building and the navigation code.
A description of the concepts and classes is added to the
docs/experimental_geometry.md
to this PR.