refactor: Large GSF refactoring #1629
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andiwand
approved these changes
Nov 9, 2022
andiwand
approved these changes
Nov 9, 2022
|
Hmm the trackstate hashes seem to be not reproducible... Maybe we have uninitialized memory somethere, I'll check that. |
|
or rng maybe? |
Then that's a problem too because all RNGs should be pseudo. |
|
I'm pretty sure the reason is that I ask the MultiTrajectory to allocate memory for smoothed, but do not assign it, also because only trackstates hashes differ and not the tracksummary hashes... |
andiwand
approved these changes
Nov 11, 2022
CarloVarni
pushed a commit
to CarloVarni/acts
that referenced
this pull request
Dec 22, 2022
This is a major refactoring of the GSF. It changes the propagation structure, and the way the GSF records states to the `MultiTrajectory`. It also removes the smoothing code, since it is not really useful at the moment, as the component states are not exported anyways. should be merged after acts-project#1609 and acts-project#1627 and acts-project#1628 We should add performance monitoring in this or a later PR Fixes acts-project#1666
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a major refactoring of the GSF. It changes the propagation structure, and the way the GSF records states to the
MultiTrajectory. It also removes the smoothing code, since it is not really useful at the moment, as the component states are not exported anyways.should be merged after #1609 and #1627 and #1628
We should add performance monitoring in this or a later PR
Fixes #1666