Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: GSF crashes with a segmentation error (single electron, ATLAS production) #1666

Closed
Maury98 opened this issue Nov 9, 2022 · 4 comments · Fixed by #1629
Closed

Bug: GSF crashes with a segmentation error (single electron, ATLAS production) #1666

Maury98 opened this issue Nov 9, 2022 · 4 comments · Fixed by #1629
Assignees
Labels
Bug Something isn't working

Comments

@Maury98
Copy link
Contributor

Maury98 commented Nov 9, 2022

I'm currently doing refitting of ATLAS tracks inside Athena (the ATLAS software environment) with the ACTS GSF, so calling the fit function of GSF.
On some events, a crash (segmentation fault) occurs just after calling the fit function from GaussianSumFitter.hpp#L139 and before this function returns its result, so it does not come from the ATLAS-side code. As of now, I am not able to obtain a verbose output from the GSF fitter ACTS-side.

To reproduce the error, one would need access to ATLAS' files and environment:

  1. locally compile https://gitlab.cern.ch/armaury/athena-acts-gsf-refitting/-/tree/gsf_uptodate (branch "gsf_uptodate") with the following packages in the package_filter.txt:
    • Tracking/Acts/ActsTrkAlgs/ActsTrkAnalysis
    • Tracking/Acts/ActsTrkAlgs/ActsTrkFittingAlgs
    • Tracking/Acts/ActsTrkTools/ActsTrkFittingTools
  1. Get an RDO (single electron, no pileup) such as from mc15_14TeV.900032.PG_singleel_Pt1_etaFlatnp0_43.recon.RDO.e8185_s3856_r13995 to run on, e.g. the RDO.30737808._000001.pool.root.1 crashes after having processed 163 events, so at event n°164.
  2. Run the following Reco_tf.py:
Reco_tf.py --CA --autoConfiguration 'everything' --steering doRAWtoALL --detectors ITkStrip ITkPixel Bpipe --preExec "ConfigFlags.Reco.EnableHGTDExtension = False;" \
  --preInclude "InDetConfig.ConfigurationHelpers.OnlyTrackingPreInclude" --postInclude "ActsTrkFittingAlgs.ActsTrkFittingAlgsConfig.ActsReFitterGSFAlgCfg" \
  --inputRDOFile ... --outputAODFile ... --maxEvents -1

[Bug]

@benjaminhuth benjaminhuth added the Bug Something isn't working label Nov 10, 2022
@benjaminhuth benjaminhuth self-assigned this Nov 10, 2022
@benjaminhuth
Copy link
Member

benjaminhuth commented Nov 10, 2022

So without a stack trace or verbose log it is difficult to say where the error exactely comes from. That would be the first step. What is the exact issue with the VERBOSE output?

It might be possible that it will be fixed by the large GSF refactor I'm currently doing (#1629). Is it easy possible to compile ACTS with this branch and check if it is still present?

@Maury98
Copy link
Contributor Author

Maury98 commented Nov 10, 2022

I run the Reco_tf.py with those additionnal flags: --verbose --multithreaded=False --multiprocess=False.
Here is a link to the log file when running the above command (Reco_tf.py ...) with the above mentionned RDO file: https://cernbox.cern.ch/s/ikiPkpvJVFSULGt

@Maury98
Copy link
Contributor Author

Maury98 commented Nov 10, 2022

Yes, I'm currently looking into compiling and using a custom ACTS build with Athena. I'll try using your refactor/gsf-big-refactoring branch from your fork then

@benjaminhuth
Copy link
Member

Ah here we go:

RAWtoALL 10:44:30 ActsReFitterAlg.ActsKalma...Acts GaussianSum RefitWARNING Did not find forward states on surface vol=21|lay=4|sen=2676

This should be fixed with #1629

@kodiakhq kodiakhq bot closed this as completed in #1629 Nov 11, 2022
kodiakhq bot pushed a commit that referenced this issue Nov 11, 2022
This is a major refactoring of the GSF. It changes the propagation structure, and the way the GSF records states to the `MultiTrajectory`. It also removes the smoothing code, since it is not really useful at the moment, as the component states are not exported anyways.

should be merged after #1609 and #1627 and #1628 

We should add performance monitoring in this or a later PR

Fixes #1666
CarloVarni pushed a commit to CarloVarni/acts that referenced this issue Dec 22, 2022
This is a major refactoring of the GSF. It changes the propagation structure, and the way the GSF records states to the `MultiTrajectory`. It also removes the smoothing code, since it is not really useful at the moment, as the component states are not exported anyways.

should be merged after acts-project#1609 and acts-project#1627 and acts-project#1628 

We should add performance monitoring in this or a later PR

Fixes acts-project#1666
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants