Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: helix cut calculated from duplets in orthogonal seeding #1604

Merged
merged 4 commits into from
Oct 19, 2022

Conversation

LuisFelipeCoelho
Copy link
Member

Cut on the maximum allowed curvature considering two SPs only. This is the same cut as #1207 in SeedFinder

@LuisFelipeCoelho LuisFelipeCoelho added Component - Core Affects the Core module Improvement Changes to an existing feature Component - Examples Affects the Examples module labels Oct 19, 2022
@LuisFelipeCoelho LuisFelipeCoelho added this to the next milestone Oct 19, 2022
@codecov
Copy link

codecov bot commented Oct 19, 2022

Codecov Report

Merging #1604 (decfc15) into main (02e39a4) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #1604   +/-   ##
=======================================
  Coverage   48.64%   48.64%           
=======================================
  Files         381      381           
  Lines       20785    20785           
  Branches     9519     9519           
=======================================
  Hits        10110    10110           
  Misses       4104     4104           
  Partials     6571     6571           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@LuisFelipeCoelho LuisFelipeCoelho marked this pull request as ready for review October 19, 2022 09:12
Copy link
Member

@stephenswat stephenswat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@kodiakhq kodiakhq bot merged commit b7b3e77 into acts-project:main Oct 19, 2022
@LuisFelipeCoelho LuisFelipeCoelho deleted the ipCut-orthogonal branch October 19, 2022 13:26
@paulgessinger paulgessinger modified the milestones: next, v21.0.0 Nov 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component - Core Affects the Core module Component - Examples Affects the Examples module Improvement Changes to an existing feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants